Skip to content

unused-for is a deprecated synonym for until#2179

Merged
tiborvass merged 1 commit intodocker:masterfrom
sj26:builder-prune-filter-docs
Nov 5, 2019
Merged

unused-for is a deprecated synonym for until#2179
tiborvass merged 1 commit intodocker:masterfrom
sj26:builder-prune-filter-docs

Conversation

@sj26
Copy link
Contributor

@sj26 sj26 commented Oct 30, 2019

- What I did

Change unused-for to until in docker builder prune --help output, which should flow through to the docs site.

- How I did it

Modifying the command flag description.

- How to verify it

Run docker builder prune --help

- Description for the changelog

Fixed deprecated docker builder prune filter example

- A picture of a cute animal (not mandatory but encouraged)

image

@thaJeztah
Copy link
Member

Thanks! this should probably also remove the term from the completion script;

COMPREPLY=( $( compgen -S = -W "description id inuse parent private shared type until unused-for" -- "$cur" ) )

However, I'm a bit hazy on this one; I recall there were some issues with docker builder prune vs docker prune (last one could only support "generic" filters supported by all object types, so perhaps until was mainly added as an alias so that it would work in that case). And I know this was renamed from max-age at some point; #1451

ping @tiborvass could you help out on this one?

@thaJeztah
Copy link
Member

Also; nice to see you here! I used your "mailcatcher" quite a bit in a previous job 🤗 👍

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants