Skip to content

[18.09 backport] assorted docs and completion script fixes#2002

Merged
kolyshkin merged 4 commits intodocker:18.09from
thaJeztah:18.09_backport_docs
Jul 23, 2019
Merged

[18.09 backport] assorted docs and completion script fixes#2002
kolyshkin merged 4 commits intodocker:18.09from
thaJeztah:18.09_backport_docs

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jul 12, 2019

BretFisher and others added 3 commits July 12, 2019 16:08
1. Adds `docker events` description info on the two scope types of events.
2. Adds `docker events` note in two places about backlog limit of event log.

Further info and background info in Issue 727

Signed-off-by: Bret Fisher <bret@bretfisher.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 988b9a0)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit c1639e1)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Changed `--user` to `--username`

Signed-off-by: Rohan Verma <hello@rohanverma.net>
(cherry picked from commit 1dc756e)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Matteo Orefice <matteo.orefice@bites4bits.software>
(cherry picked from commit 0b49495)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io
Copy link

Codecov Report

Merging #2002 into 18.09 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            18.09    #2002   +/-   ##
=======================================
  Coverage   54.23%   54.23%           
=======================================
  Files         290      290           
  Lines       19428    19428           
=======================================
  Hits        10537    10537           
  Misses       8212     8212           
  Partials      679      679

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #2002 into 18.09 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            18.09    #2002   +/-   ##
=======================================
  Coverage   54.23%   54.23%           
=======================================
  Files         290      290           
  Lines       19428    19428           
=======================================
  Hits        10537    10537           
  Misses       8212     8212           
  Partials      679      679

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@thaJeztah thaJeztah modified the milestones: 18.09.8, 18.09.9 Jul 18, 2019
@kolyshkin kolyshkin merged commit 642235d into docker:18.09 Jul 23, 2019
@thaJeztah thaJeztah deleted the 18.09_backport_docs branch July 23, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants