[18.09 backport] Fix Rollback config type interpolation#1978
Merged
thaJeztah merged 1 commit intodocker:18.09from Jul 3, 2019
Merged
Conversation
…ailure_ratio" were missing, as it uses the same type as update_config. Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com> (cherry picked from commit efdf36f) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
Codecov Report
@@ Coverage Diff @@
## 18.09 #1978 +/- ##
=======================================
Coverage 54.23% 54.23%
=======================================
Files 290 290
Lines 19428 19428
=======================================
Hits 10537 10537
Misses 8212 8212
Partials 679 679 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## 18.09 #1978 +/- ##
=======================================
Coverage 54.23% 54.23%
=======================================
Files 290 290
Lines 19428 19428
=======================================
Hits 10537 10537
Misses 8212 8212
Partials 679 679 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #1973
- What I did
Rollback config type interpolation on fields "parallelism" and "max_failure_ratio" were missing, as it uses the same type as update_config.
It addresses docker-archive-public/docker.app#559
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)