-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
note --user
args usage restriction
#1900
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1900 +/- ##
=======================================
Coverage 56.75% 56.75%
=======================================
Files 309 309
Lines 21680 21680
=======================================
Hits 12305 12305
Misses 8476 8476
Partials 899 899 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1900 +/- ##
=======================================
Coverage 56.75% 56.75%
=======================================
Files 309 309
Lines 21680 21680
=======================================
Hits 12305 12305
Misses 8476 8476
Partials 899 899 |
/kind docs |
/assign @thaJeztah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! I left a suggestion inline
Signed-off-by: Yucheng Wu <wyc123wyc@gmail.com>
3e6a7b4
to
5d04b1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, forgot about this one (I saw it needed squashing, so i did a quick rebase and squash)
thanks!
Signed-off-by: Yucheng Wu wyc123wyc@gmail.com
- What I did
note
--user
args usage restrictionfixes and closes: docker/docs#8831
- How I did it
add additional explanation
- How to verify it
xref: moby/moby#22323 (comment)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
haha, his name is peiqi