Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note --user args usage restriction #1900

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

yuchengwu
Copy link
Contributor

@yuchengwu yuchengwu commented May 22, 2019

Signed-off-by: Yucheng Wu wyc123wyc@gmail.com

- What I did
note --user args usage restriction
fixes and closes: docker/docs#8831

- How I did it
add additional explanation

- How to verify it
xref: moby/moby#22323 (comment)

- Description for the changelog

the user name specified by docker run `--user` args must be exist in the container

- A picture of a cute animal (not mandatory but encouraged)
peiqi
haha, his name is peiqi

@codecov-io
Copy link

Codecov Report

Merging #1900 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1900   +/-   ##
=======================================
  Coverage   56.75%   56.75%           
=======================================
  Files         309      309           
  Lines       21680    21680           
=======================================
  Hits        12305    12305           
  Misses       8476     8476           
  Partials      899      899

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1900 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1900   +/-   ##
=======================================
  Coverage   56.75%   56.75%           
=======================================
  Files         309      309           
  Lines       21680    21680           
=======================================
  Hits        12305    12305           
  Misses       8476     8476           
  Partials      899      899

@yuchengwu
Copy link
Contributor Author

/kind docs

@yuchengwu
Copy link
Contributor Author

/assign @thaJeztah

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I left a suggestion inline

docs/reference/run.md Outdated Show resolved Hide resolved
Signed-off-by: Yucheng Wu <wyc123wyc@gmail.com>
@thaJeztah thaJeztah force-pushed the 8831-doc-user-restrict branch from 3e6a7b4 to 5d04b1c Compare January 17, 2023 21:46
@thaJeztah thaJeztah added this to the 23.0.0 milestone Jan 17, 2023
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, forgot about this one (I saw it needed squashing, so i did a quick rebase and squash)

thanks!

@thaJeztah thaJeztah merged commit f7c322e into docker:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

note --user args usage restriction
5 participants