Skip to content

CircleCI: Increase no-output timeout to 15 minutes for vendoring#1750

Merged
silvin-lubecki merged 1 commit intodocker:masterfrom
thaJeztah:fix_circle_vendor_flakiness
Mar 18, 2019
Merged

CircleCI: Increase no-output timeout to 15 minutes for vendoring#1750
silvin-lubecki merged 1 commit intodocker:masterfrom
thaJeztah:fix_circle_vendor_flakiness

Conversation

@thaJeztah
Copy link
Member

Vendoring can take some time, depending on network-speed, so
reduce flakiness by increasing the default timeout, to prevent:

make[1]: Entering directory '/go/src/github.com/docker/cli'
rm -rf vendor
bash -c 'vndr |& grep -v -i clone'
2019/03/18 11:38:26 Collecting initial packages
Too long with no output (exceeded 10m0s)

Vendoring can take some time, depending on network-speed, so
reduce flakiness by increasing the default timeout, to prevent:

    make[1]: Entering directory '/go/src/github.com/docker/cli'
    rm -rf vendor
    bash -c 'vndr |& grep -v -i clone'
    2019/03/18 11:38:26 Collecting initial packages
    Too long with no output (exceeded 10m0s)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

ping @silvin-lubecki @vdemeester ptal 🤗

@thaJeztah
Copy link
Member Author

Not sure if this is the best solution, but the time for this step looks to be fluctuating a bit;
Screenshot 2019-03-18 at 13 11 49
Screenshot 2019-03-18 at 13 12 27
Screenshot 2019-03-18 at 13 12 57

@codecov-io
Copy link

Codecov Report

Merging #1750 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1750   +/-   ##
======================================
  Coverage    56.1%   56.1%           
======================================
  Files         306     306           
  Lines       21049   21049           
======================================
  Hits        11810   11810           
  Misses       8382    8382           
  Partials      857     857

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit 🦁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants