Allow flags to be passed to e2e tests#1704
Merged
thaJeztah merged 2 commits intodocker:masterfrom Mar 19, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1704 +/- ##
=======================================
Coverage 56.14% 56.14%
=======================================
Files 306 306
Lines 21031 21031
=======================================
Hits 11807 11807
Misses 8369 8369
Partials 855 855 |
thaJeztah
reviewed
Mar 1, 2019
added 2 commits
March 11, 2019 15:59
This allows e.g.
$ make -f docker.Makefile fmt test-e2e-non-experimental TESTFLAGS="-test.run TestRunGoodArgument|TestRunGood"
As well as adding the var to `$(ENVVARS)` we also need to use that when
invocking the e2e image, the existing `$(DOCKER_RUN)` is not used here because
the bind mounts differ. The other variables included in `$(ENVVARS)` are
harmless when running the e2e tests.
The `${TESTFLAGS}` envvar is already understood by `scripts/test/e2e/run`.
Note that since this modifies `$(ENVVARS)` this is now also available to the unit
test target too, so add the use to the invocation so it takes effect.
Signed-off-by: Ian Campbell <ijc@docker.com>
Allows e.g.:
$ make -f docker.Makefile TESTDIRS=./cli/command/trust/... test-unit
Signed-off-by: Ian Campbell <ijc@docker.com>
ijc
force-pushed
the
allow-passing-args-to-e2e-tests
branch
from
6ccadf1 to
e1a7b56
Compare
Contributor
Author
|
Rebased and switched to I also added |
thaJeztah
reviewed
Mar 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows e.g.
Signed-off-by: Ian Campbell ijc@docker.com