Engine CLI 404

[paigehargrave]

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[GordonTheTurtle]

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "Engine-CLI-404-redirect" git@github.com:paigehargrave/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

[paigehargrave]

@thaJeztah - PTAL - thank you!

[thaJeztah]

Left some comments below; also looks like this is missing a sign-off, which is needed to make CI pass (see the comments that @GordonTheTurtle left), and we'll need the commits squashed after review.

[thaJeztah]

Could you explain this redirect? Because the archive still exists at this location; https://docs.docker.com/v1.11/engine/reference/commandline/daemon/

[JustinINevill]

Our policy is to document all currently supported versions, plus the most recently EOL'd version (to support upgrades from that version), therefore we are removing all docs content for versions old than 17.03 to reduce the associated maintenance burden and customer confusion. These pages account for < 0.75% of current site traffic and are already not indexed by search engine. However out of an abundance of caution we are implementing a handful of redirects for the most popular pages within this <0.75%. This PR implements those redirect for those pages.

[thaJeztah]

Have we tested if this actually works? Because I think it won't;

• These markdown files are not used for docs.docker.com (they have been replaced by stubs; https://github.com/docker/docker.github.io/tree/master/engine/reference/commandline that are propagated with the generated YAML files (see Update commandline yaml docs docs#7753)
• If the redirect is created, we should check if it is not overwritten by the archive itself (https://github.com/docker/docker.github.io/blob/master/Dockerfile#L69-L83)

Also, once the "current" docs will be archived, possibly this redirect will now become;

/v18.09/v1.11/engine/reference/commandline/daemon/

Which will become a maintenance nightmare (also; what about version /v1.12/, /v1.13/)?

Would it be an alternative to, once we decide to no longer publish archives for a specific version, to replace an archive /vYY.MM/* to redirect to / ? (or show a landing-page, informing the user that that specific archive is no longer published?)

[thaJeztah]

Same for this one

https://docs.docker.com/v1.11/engine/reference/commandline/run/

[JustinINevill]

Same answer as above.

[codecov-io]

Codecov Report

Merging #1607 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1607   +/-   ##
=======================================
  Coverage   55.38%   55.38%           
=======================================
  Files         283      283           
  Lines       19305    19305           
=======================================
  Hits        10692    10692           
  Misses       7919     7919           
  Partials      694      694

[JustinINevill]

We believe we can accomplish the same outcome in a more simple way. @paigehargrave can you go ahead and close this?

[paigehargrave]

Closing this based on previous conversations.