build: update session support detection#1474
Merged
tiborvass merged 1 commit intodocker:masterfrom Oct 22, 2018
Merged
Conversation
Avoid testing for session support in non-buildkit builder to support servers that falsely report as `1.39` compatible Signed-off-by: Tibor Vass <tibor@docker.com>
tiborvass
force-pushed
the
fix-build-stream
branch
from
6620516 to
3e8c41b
Compare
tiborvass
changed the title
andrewhsu
approved these changes
Oct 22, 2018
Contributor
andrewhsu
left a comment
andrewhsu
left a comment
There was a problem hiding this comment.
LGTM
helpful for getting legacy docker build working with mismatched version API implementation
tonistiigi
approved these changes
Oct 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid testing for session support in non-buildkit builder to support
servers that falsely report as
1.39compatible