Enhancement: don't need to type ssh password twice when docker logs with ssh#1472
Merged
silvin-lubecki merged 1 commit intodocker:masterfrom Oct 26, 2018
Merged
Enhancement: don't need to type ssh password twice when docker logs with ssh#1472silvin-lubecki merged 1 commit intodocker:masterfrom
silvin-lubecki merged 1 commit intodocker:masterfrom
Conversation
Contributor
Author
|
@AkihiroSuda PTAL |
Codecov Report
@@ Coverage Diff @@
## master #1472 +/- ##
==========================================
- Coverage 54.19% 54.19% -0.01%
==========================================
Files 289 289
Lines 19382 19377 -5
==========================================
- Hits 10505 10502 -3
- Misses 8198 8199 +1
+ Partials 679 676 -3 |
AkihiroSuda
approved these changes
Oct 25, 2018
cpuguy83
reviewed
Oct 25, 2018
Signed-off-by: Lifubang <lifubang@acmcoder.com>
silvin-lubecki
approved these changes
Oct 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lifubang lifubang@acmcoder.com
- What I did
When use ssh host, docker logs need user to type password twice.
- How I did it
Because ContainerInspect is behind ContainerLogs, but ContainerLogs don't close the response, so ContainerInspect can't reuse the connection.
So, move ContainerInspect to the ahead of ContainerLogs.
- How to verify it
- Description for the changelog
Move ContainerInspect to the ahead of ContainerLogs, so we can reuse docker host connection.
- A picture of a cute animal (not mandatory but encouraged)
