Merged
Conversation
Removes the billing profile flow which is now handled on the back-end. Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
dhiltgen
force-pushed
the
bump_licensing_lib
branch
from
1da07e2 to
0ff9e5c
Compare
Codecov Report
@@ Coverage Diff @@
## 18.09 #1458 +/- ##
=======================================
Coverage 54.07% 54.07%
=======================================
Files 290 290
Lines 19391 19391
=======================================
Hits 10485 10485
Misses 8237 8237
Partials 669 669 |
andrewhsu
approved these changes
Oct 18, 2018
Contributor
andrewhsu
left a comment
andrewhsu
left a comment
There was a problem hiding this comment.
LGTM
this will help get docker engine activate to work with trial licenses for 18.09.0
Contributor
|
LGTM |
silvin-lubecki
approved these changes
Oct 19, 2018
Contributor
Author
|
@andrewhsu I tried to forward port this to master, but it looks like we're a bit behind and it had a merge conflict. Not sure how you want to track that so it doesn't fall through the cracks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the billing profile flow which is now handled on the back-end.