Clarify in docs that docker tag doesn't publish#1418
Merged
albers merged 1 commit intodocker:masterfrom Oct 5, 2018
Merged
Conversation
|
Please sign your commits following these rules: $ git clone -b "docker-image-tag-docs" git@github.com:jake-lambert-volusion/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
I am attempting to push a tag to a private repository. The documentation for `docker tag` has an explicit example to for how ["To push an image to a private registry"](https://docs.docker.com/engine/reference/commandline/tag/#tag-an-image-referenced-by-name). My colleague clarified that this command does not in fact push anything, so I thought this PR might save some future novice the same confusion. Signed-off-by: Jake Lambert <jake.lambert@volusion.com>
jake-lambert-volusion
force-pushed
the
docker-image-tag-docs
branch
from
009a15f to
4ed484b
Compare
Contributor
Author
|
@GordonTheTurtle Done |
Codecov Report
@@ Coverage Diff @@
## master #1418 +/- ##
=======================================
Coverage 54.26% 54.26%
=======================================
Files 289 289
Lines 19331 19331
=======================================
Hits 10490 10490
Misses 8165 8165
Partials 676 676 |
silvin-lubecki
approved these changes
Oct 4, 2018
Contributor
silvin-lubecki
left a comment
silvin-lubecki
left a comment
There was a problem hiding this comment.
LGTM, thank you for you first PR @jake-lambert-volusion ! Hope there will be many others 😉
Contributor
|
(And by the way no need to answer @GordonTheTurtle , it's our bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR, just to clarify docs which confused me as a newcomer. Please let me know if I can do anything better.
I am attempting to push a tag to a private repository. The documentation for
docker taghas an explicit example to for how "To push an image to a private registry". My colleague clarified that this command does not in fact push anything, so I thought this PR might save some future novice the same confusion.- What I did
I changed the wording in the docker image tag docs which implied that the tag command would push an image.
- How I did it
I forked the repo and edited man/src/image/tag.md in GitHub.
- How to verify it
I don't know.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)