[18.09] vndr docker/docker to docker/engine d2ecc7b#1339
Merged
andrewhsu merged 1 commit intodocker:18.09from Sep 5, 2018
andrewhsu:vr
Merged
[18.09] vndr docker/docker to docker/engine d2ecc7b#1339andrewhsu merged 1 commit intodocker:18.09from andrewhsu:vr
andrewhsu merged 1 commit intodocker:18.09from
andrewhsu:vr
Conversation
Codecov Report
@@ Coverage Diff @@
## 18.09 #1339 +/- ##
=====================================
Coverage 54.6% 54.6%
=====================================
Files 294 294
Lines 19417 19417
=====================================
Hits 10602 10602
Misses 8149 8149
Partials 666 666 |
And update the associated packages that have also updated from docker/docker vendor.conf. Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Contributor
Author
|
So much vndr |
Member
|
Did you check if there were corresponding vndr PR's in the docker/engine 18.09 branch? I tend to cherry-pick those vendor-bump PR's, which also allows me to double check if no local changes were associated and/or to make it easier to link related issues |
Member
|
Actually; ignore my previous comment. Not thinking straight due to queuing at the airport 😁😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
update docker/docker vndr to d2ecc7b of docker/engine 18.09 branch and the associated vndrs of the vendor.conf
for reference, comparison of upstream changes:
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
🐳