Skip to content

Add: Add missing option#1145

Merged
thaJeztah merged 1 commit intodocker:masterfrom
Vimal-Raghubir:590-Add-missing-option
Jun 29, 2018
Merged

Add: Add missing option#1145
thaJeztah merged 1 commit intodocker:masterfrom
Vimal-Raghubir:590-Add-missing-option

Conversation

@Vimal-Raghubir
Copy link
Contributor

Closes #590.
- What I did
I added the shutdown-timeout option to the dockerd configuration documentation.
- How I did it
Went to the required file and added the option with a description after the existing options.
- How to verify it
Preview changes made.
- Description for the changelog

Added missing option to dockerd configuration documentation.

- A picture of a cute animal (not mandatory but encouraged)
cute pug

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "590-Add-missing-option" git@github.com:Vimal-Raghubir/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@thaJeztah
Copy link
Member

Thanks! Looks like you forgot to sign-off the commit; can you amend your commit (with the instructions that @GordonTheTurtle (our bot) gave above)?

Signed-off-by: Vimal-Raghubir <vraghubir0418@gmail.com>
@Vimal-Raghubir
Copy link
Contributor Author

Vimal-Raghubir commented Jun 28, 2018

Hi @thaJeztah. I have signed off the commit and was wondering if you could kindly review this PR. Thank you.

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit da59ccb into docker:master Jun 29, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.07.0 milestone Jun 29, 2018
@Vimal-Raghubir Vimal-Raghubir deleted the 590-Add-missing-option branch June 29, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dockerd configuration reloading section missing options that get reloaded

4 participants