-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Compose file] allow names for non-external volumes #274
Comments
cc @vdemeester as well |
Seems reasonable. |
In reference to moby/moby#30770 Will this change make templated names for volumes possible in the compose YML file used by docker stack deploy like below -
equivalent of the command line -
|
Yes, that is one of the problems that will be fixed by this change. |
@dnephin thanks for confirming |
I Think this fix will be great! When will this be implemented? Thanks! |
@eliaoggian yes see #306 need to wait for 3.4 version of the schema with some other changes. I guess we can't expect a GA until 17.09 @dnephin right? |
@dnephin @thaJeztah should this one be closed ? |
Yes, this issue is closed, fixed by #306 |
I'm trying to use version 3.4 but it doesn't seem to work. The relevant configuration is:
However, only a single volume is created with the task.slot from the container in the manager and all tasks attempt to attatch to it. Am I doing something wrong? |
It depends if the docker release you run on aws, which one are you running? |
Here
|
Proposed syntax:
This will fix a bunch of issues:
Probably others I haven't found yet.
We should also deprecate
external: name: foo
(external: bool
would remain undeprecated).cc @shin- What do you think?
Also, should we go ahead and do this with secrets, configs and networks as well, to keep them consistent?
The text was updated successfully, but these errors were encountered: