Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: docker/cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: baeda1f
Choose a base ref
...
head repository: docker/cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3a2c30b
Choose a head ref
  • 20 commits
  • 76 files changed
  • 7 contributors

Commits on Nov 5, 2022

  1. [20.10] update to Go 1.18.8 to address CVE-2022-41716

        On Windows, syscall.StartProcess and os/exec.Cmd did not properly
        check for invalid environment variable values. A malicious
        environment variable value could exploit this behavior to set a
        value for a different environment variable. For example, the
        environment variable string "A=B\x00C=D" set the variables "A=B" and
        "C=D".
    
        Thanks to RyotaK (https://twitter.com/ryotkak) for reporting this
        issue.
    
        This is CVE-2022-41716 and Go issue https://go.dev/issue/56284.
    
    This Go release also fixes golang/go#56309, a
    runtime bug which can cause random memory corruption when a goroutine
    exits with runtime.LockOSThread() set. This fix is necessary to unblock
    work to replace certain uses of pkg/reexec with unshared OS threads.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    acc3f99 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Merge pull request #3851 from thaJeztah/20.10_bump_go_1.18.8

    [20.10] update to Go 1.18.8 to address CVE-2022-41716
    thaJeztah authored Nov 15, 2022
    Configuration menu
    Copy the full SHA
    a9d9bbf View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. vendor.conf: golang.org/x/crypto v0.1.0

    Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
    AkihiroSuda committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    2d4e433 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3862 from AkihiroSuda/x-crypto-v0.2.0-docker-20.10

    [20.10] vendor.conf: golang.org/x/crypto v0.1.0 (Fix `ssh: parse error in message type 27` with OpenSSH >= 8.9)
    thaJeztah authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    a60bf81 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2022

  1. Dockerfile: add ALPINE_VERSION build-arg

    This allows us to pin to a specific version of Alpine, in case the
    golang:alpine image switches to a newer version, which may at times
    be incompatible, e.g. see moby/moby#44570
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    (cherry picked from commit 1b0d6fc)
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    34fae41 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3897 from thaJeztah/20.10_backport_add_alpine_ver…

    …sion
    
    [20.10 backport] Dockerfile: add ALPINE_VERSION build-arg
    thaJeztah authored Dec 4, 2022
    Configuration menu
    Copy the full SHA
    9124a42 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. [20.10] update to go1.18.9

    Includes security fixes for net/http (CVE-2022-41717, CVE-2022-41720),
    and os (CVE-2022-41720).
    
    These minor releases include 2 security fixes following the security policy:
    
    - os, net/http: avoid escapes from os.DirFS and http.Dir on Windows
    
      The os.DirFS function and http.Dir type provide access to a tree of files
      rooted at a given directory. These functions permitted access to Windows
      device files under that root. For example, os.DirFS("C:/tmp").Open("COM1")
      would open the COM1 device.
      Both os.DirFS and http.Dir only provide read-only filesystem access.
    
      In addition, on Windows, an os.DirFS for the directory \(the root of the
      current drive) can permit a maliciously crafted path to escape from the
      drive and access any path on the system.
    
      The behavior of os.DirFS("") has changed. Previously, an empty root was
      treated equivalently to "/", so os.DirFS("").Open("tmp") would open the
      path "/tmp". This now returns an error.
    
      This is CVE-2022-41720 and Go issue https://go.dev/issue/56694.
    
    - net/http: limit canonical header cache by bytes, not entries
    
      An attacker can cause excessive memory growth in a Go server accepting
      HTTP/2 requests.
    
      HTTP/2 server connections contain a cache of HTTP header keys sent by
      the client. While the total number of entries in this cache is capped,
      an attacker sending very large keys can cause the server to allocate
      approximately 64 MiB per open connection.
    
      This issue is also fixed in golang.org/x/net/http2 vX.Y.Z, for users
      manually configuring HTTP/2.
    
      Thanks to Josselin Costanzi for reporting this issue.
    
      This is CVE-2022-41717 and Go issue https://go.dev/issue/56350.
    
    View the release notes for more information:
    https://go.dev/doc/devel/release#go1.18.9
    
    And the milestone on the issue tracker:
    https://github.com/golang/go/issues?q=milestone%3AGo1.18.9+label%3ACherryPickApproved
    
    Full diff: golang/go@go1.18.8...go1.18.9
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    28b7a35 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Merge pull request #3908 from thaJeztah/20.10_update_go_1.18.9

    [20.10] update to go1.18.9
    thaJeztah authored Dec 7, 2022
    Configuration menu
    Copy the full SHA
    9835d5d View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. update gotestsum to v1.8.2

    release notes: https://github.com/gotestyourself/gotestsum/releases/tag/v1.8.2
    
    - Show shuffle seed
    - Update tests, and cleanup formats
    - Update dependencies
    - Test against go1.19, remove go1.15
    - Add project name to junit.xml output
    - Adding in support for s390x and ppc64le
    
    full diff: gotestyourself/gotestsum@v1.8.1...v1.8.2
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    (cherry picked from commit 7000991)
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    2d3c405 View commit details
    Browse the repository at this point in the history
  2. docs: reference: version: improve description

    Move the "default output" section into the description, and
    describe the section that can be found in the output.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    (cherry picked from commit 99bb525)
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    0b421dc View commit details
    Browse the repository at this point in the history
  3. docs: fix misleading example of setting an env variable for a single …

    …command
    
    The `DEBIAN_FRONTEND` environment variable is used to control the interface by which debconf questions are presented to the user (see [`man 7 debconf`][1]). In `DEBIAN_FRONTEND=noninteractive apt-get update && apt-get install -y`, the `DEBIAN_FRONTEND` environment variable is only set for the `apt-get update` command which does not ask debconf questions, and will not affect the `apt-get install` command where these questions are actually asked. It should be the other way around.
    
      [1]: https://manpages.debian.org/debconf.7.html
    
    Signed-off-by: Murukesh Mohanan <murukesh.mohanan@gmail.com>
    (cherry picked from commit 7227c01)
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    muru authored and thaJeztah committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    0c8ce43 View commit details
    Browse the repository at this point in the history
  4. docs: use correct separator in --security-opt

    > Security options with `:` as a separator are deprecated and will be completely unsupported in 17.04, use `=` instead.
    
    Signed-off-by: Felix Geyer <debfx@fobos.de>
    (cherry picked from commit 4648c00)
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    debfx authored and thaJeztah committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    42eca75 View commit details
    Browse the repository at this point in the history
  5. docs: docker inspect: reformat with prettier

    Signed-off-by: David Karlsson <david.karlsson@docker.com>
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    (cherry picked from commit 802c53f)
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    David Karlsson authored and thaJeztah committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    226a2fd View commit details
    Browse the repository at this point in the history
  6. docs: docker inspect --size

    Signed-off-by: David Karlsson <david.karlsson@docker.com>
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    (cherry picked from commit e064f89)
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    058f7df View commit details
    Browse the repository at this point in the history
  7. Remove deprecated note

    With dual logging enabled by default, `docker logs` works regardless of the logging driver used
    
    Signed-off-by: Mathieu Rollet <matletix@gmail.com>
    (cherry picked from commit 1158788)
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    matletix authored and thaJeztah committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    ce10682 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #3917 from thaJeztah/20.10_backport_update_gotestsum

    [20.10 backport] update gotestsum to v1.8.2
    thaJeztah authored Dec 15, 2022
    Configuration menu
    Copy the full SHA
    5106d8e View commit details
    Browse the repository at this point in the history
  9. Merge pull request #3918 from thaJeztah/20.10_docs_backports

    [20.10 backport] assorted docs fixes
    thaJeztah authored Dec 15, 2022
    Configuration menu
    Copy the full SHA
    e7cdabe View commit details
    Browse the repository at this point in the history
  10. vendor: github.com/moby/buildkit v0.8.4-0.20221020190723-eeb7b65ab7d6

    full diff: moby/buildkit@c014937...eeb7b65
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    3b562e9 View commit details
    Browse the repository at this point in the history
  11. vendor: github.com/docker/docker v20.10.21

    full diff: moby/moby@v20.10.20...v20.10.21
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    47649fb View commit details
    Browse the repository at this point in the history
  12. Merge pull request #3919 from thaJeztah/20.10_update_engine

    [20.10] update docker/docker and buildkit
    thaJeztah authored Dec 15, 2022
    Configuration menu
    Copy the full SHA
    3a2c30b View commit details
    Browse the repository at this point in the history
Loading