Open
Conversation
Member
dgageot
commented
Feb 27, 2026
- Better grouping
- Sort by name
The speak command (macOS-only) was appended after the Settings commands, causing the category sequence Session → Settings → Session. This made buildLines render a second Session header. Extract Settings into its own builtInSettingsCommands function and reorder categories in BuildCommandCategories so that Settings appears before Feedback, which is always last. Assisted-By: cagent
Reorder all built-in command groups (Session, Settings, Feedback) so items appear alphabetically by label. Dynamic groups (Agent Commands, MCP Prompts, Skills) are now sorted at runtime via a sortByLabel helper. Assisted-By: cagent
There was a problem hiding this comment.
Review Summary
Looks good! The code refactoring improves organization by splitting session and settings commands into separate functions and adds proper alphabetical sorting. No functional issues found in the changed code.
✅ The new sortByLabel function correctly sorts commands alphabetically.
✅ The builtInSettingsCommands and builtInFeedbackCommands separation improves code organization.
✅ The ParseSlashCommand function properly iterates through both session and settings commands.
✅ Category ordering (Session, Agent Commands, MCP Prompts, Skills, Settings, Feedback) is logical and well-structured.
The refactoring maintains backward compatibility while improving maintainability.
rumpl
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.