Skip hidden directories in recursive skill loading#1875
Open
dgageot wants to merge 1 commit intodocker:mainfrom
Open
Skip hidden directories in recursive skill loading#1875dgageot wants to merge 1 commit intodocker:mainfrom
dgageot wants to merge 1 commit intodocker:mainfrom
Conversation
Return fs.SkipDir for hidden directories and symlinks instead of descending into them. This avoids walking large trees like .git, .node_modules, or .cache that can never contain skills. Assisted-By: cagent
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
✅ This PR effectively optimizes directory traversal by skipping hidden directories like .git, .node_modules, and .cache early using fs.SkipDir. The logic correctly handles the root directory edge case.
Note
One minor behavioral change: the refactored code no longer filters out hidden or symlinked skill files (e.g., .SKILL.md or symlinked SKILL.md), only hidden directories. The original code checked isHiddenOrSymlink(d) for both directories and files, but the new code only applies this check to directories (line 222). This may be intentional since hidden skill files are rare, but it's worth noting the behavior change.
Member
|
I'm not sure about symlinks though, seems like something someone would do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return fs.SkipDir for hidden directories and symlinks instead of descending into them. This avoids walking large trees like .git, .node_modules, or .cache that can never contain skills.
Assisted-By: cagent