feat: allow docker-agent[bot] to trigger /review#65
Merged
derekmisler merged 1 commit intodocker:mainfrom Mar 3, 2026
Merged
Conversation
The manual-review job previously blocked all Bot-type users from triggering /review. This adds an exception for docker-agent[bot] so automated workflows (like issue triage) can request PR reviews.
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review Summary
✅ APPROVED — No issues found.
This PR correctly implements the intended logic:
- Non-bot users can trigger
/reviewcommands (unchanged behavior) docker-agent[bot]is explicitly whitelisted to trigger/review- All other bots remain blocked
The boolean logic (user.type != 'Bot' || user.login == 'docker-agent[bot]') properly allows:
- Any non-bot user (first clause)
- The specific bot
docker-agent[bot](second clause) - Rejects all other bots (both clauses false)
The implementation is secure and follows GitHub Actions best practices for user identity verification.
derekmisler
added a commit
to derekmisler/docker-agent
that referenced
this pull request
Mar 2, 2026
Auto-review checks org membership, which bots fail. The /review command path (manual-review job) bypasses the org check, so we need to post the comment explicitly. Requires docker/cagent-action#65 to allow the bot.
trungutt
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker-agent[bot]to trigger/reviewvia PR commentsThis enables automated workflows (e.g., issue triage in
docker/cagent) to request AI reviews on PRs they create.Test plan
docker-agent[bot]comment/reviewon a PR — verify the manual-review job triggers/review— verify it is still blocked/review— verify it still works as before