Skip to content

--generate-notes uses the commit graph, not semver ordering #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
derekmisler wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −5
Open

--generate-notes uses the commit graph, not semver ordering #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ jobs:
done

echo "version=$NEW_VERSION" >> $GITHUB_OUTPUT
echo "New version: $NEW_VERSION"
echo "previous=${LATEST_TAG}" >> $GITHUB_OUTPUT
echo "New version: $NEW_VERSION (previous: ${LATEST_TAG:-none})"

# CI cannot push commits to main (branch protection). Instead, we create
# a detached release commit with pinned refs, reachable only via tags.
Expand Down Expand Up @@ -128,8 +129,14 @@ jobs:
- name: Create GitHub Release
env:
VERSION: ${{ steps.version.outputs.version }}
PREVIOUS: ${{ steps.version.outputs.previous }}
GH_TOKEN: ${{ secrets.RELEASE_TOKEN }}
run: gh release create "$VERSION" --generate-notes --latest
run: |
ARGS=(--generate-notes --latest)
if [ -n "$PREVIOUS" ]; then
ARGS+=(--notes-start-tag "$PREVIOUS")
fi
gh release create "$VERSION" "${ARGS[@]}"

- name: Update latest tag
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/review-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ jobs:
manual-review:
if: |
github.event.issue.pull_request &&
contains(github.event.comment.body, '/review') &&
startsWith(github.event.comment.body, '/review') &&
github.event.comment.user.type != 'Bot'
runs-on: ubuntu-latest
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/self-review-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ jobs:
# Triggers when someone comments /review on a PR
# ==========================================================================
manual-review:
if: github.event.issue.pull_request && contains(github.event.comment.body, '/review')
if: github.event.issue.pull_request && startsWith(github.event.comment.body, '/review')
runs-on: ubuntu-latest
env:
HAS_APP_SECRETS: ${{ secrets.CAGENT_REVIEWER_APP_ID != '' }}
Expand Down
2 changes: 1 addition & 1 deletion review-pr/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ permissions:

jobs:
review:
if: github.event.issue.pull_request && contains(github.event.comment.body, '/review')
if: github.event.issue.pull_request && startsWith(github.event.comment.body, '/review')
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
Loading