release workflow needs the workflows permission#59
Conversation
ac1fdea to
63154b8
Compare
|
/review |
63154b8 to
490205e
Compare
There was a problem hiding this comment.
Review Summary
Looks good! The changes properly address the GitHub security requirement for the workflows write permission. The code correctly references secrets.RELEASE_TOKEN in both the checkout action and the gh release create command. The implementation is syntactically correct and follows GitHub Actions best practices.
Note: Ensure that the RELEASE_TOKEN secret is configured in the repository settings with the appropriate permissions (contents: write and workflows: write) before merging.
|
/describe |
|
✅ PR description has been generated and updated! |
There was a problem hiding this comment.
Review Summary
This PR correctly switches from github.token to secrets.RELEASE_TOKEN to gain the workflows: write permission required by GitHub's push protection when creating releases that modify workflow files.
All code changes are appropriate for the stated purpose. No bugs found in the changed code.
Signed-off-by: Derek Misler <derek.misler@docker.com>
490205e to
e31083a
Compare
Summary
The release workflow was failing because it requires a Personal Access Token (PAT) with the
workflowspermission to push changes back to the repository. This PR replaces the defaultgithub.tokenwith aRELEASE_TOKENsecret in two places within the release workflow, and bumpsCAGENT_VERSIONtov1.27.1.Changes
.github/workflows/release.yml: Passessecrets.RELEASE_TOKENas thetokenfor theactions/checkoutstep (enabling authenticated pushes with the necessaryworkflowspermission) and replacesgithub.tokenwithsecrets.RELEASE_TOKENfor thegh release createstep.CAGENT_VERSION: Bumped fromv1.27.0tov1.27.1.How to Test
RELEASE_TOKENsecret is configured in the repository settings with theworkflowsscope before running.