Merged
Conversation
Signed-off-by: Derek Misler <derek.misler@docker.com>
There was a problem hiding this comment.
Review Summary
The timeout fix from 300000ms to 300s is excellent and fixes a critical bug. The workflow job inlining looks solid and achieves the dogfooding goal.
However, there's a high-severity bug in the fallback regex for markdown extraction in pr-describe.yml. The pattern requires no trailing whitespace to match, which will cause it to fail in most real-world scenarios and fall back to exposing the raw output (including tool traces), defeating the security measure.
Recommendation: Fix the regex pattern before merging.
rumpl
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
pr-describeworkflow timeout (was milliseconds, should be seconds) and improves its output extraction fallback. Replaces theself-review-prworkflow's 3-line reusable-workflow delegation with fully inlined jobs so that PRs changing the review logic dogfood themselves.Changes
pr-describe.yml300000(milliseconds — ~83 hours) to300(seconds — 5 minutes) to match theaction.ymltimeout input spec```cagent-outputcode fence: extract from the first##heading onward, avoiding tool-call traces leaking into the PR bodyself-review-pr.ymluses: ./.github/workflows/review-pr.yml/secrets: inheritdelegation with inlined jobs so that changes to./review-prare tested by the PR that introduces themauto-reviewjob — runs onpull_request_targetfor non-draft PRs; gates on Docker org membership viaCAGENT_ORG_MEMBERSHIP_TOKENbefore checking out the PR head and running./review-prmanual-reviewjob — runs on/reviewcomment; checks out the PR head and runs./review-pr(authorization delegated to the composite action's built-in check)capture-feedbackjob — captures replies to agent review comments as artifacts for async processing; intentionally avoids secrets so it works on fork PRscontinue-on-error: trueto avoid failing the calling workflowgithub.token)Test plan
auto-reviewjob triggers for org members, skips for non-members/reviewon a PR →manual-reviewjob triggers and posts a reviewcapture-feedbackjob uploads the feedback artifactpr-describeworkflow completes within 5 minutes instead of hanging for hourscagent-outputcode fence (falls back to heading extraction)Tip
Comment
/reviewto trigger the PR Reviewer agent for automated feedback.Comment
/describeto generate a PR description.