Skip to content

local version of the PR reviewer#49

Merged
derekmisler merged 1 commit intodocker:mainfrom
derekmisler:local-version-of-the-pr-reviewer
Feb 20, 2026
Merged

local version of the PR reviewer#49
derekmisler merged 1 commit intodocker:mainfrom
derekmisler:local-version-of-the-pr-reviewer

Conversation

@derekmisler
Copy link
Contributor

@derekmisler derekmisler commented Feb 19, 2026

Summary

  • Adds local development support to the PR reviewer agent, allowing developers to run reviews on their local branches without posting to GitHub.
  • Publishes the agent to Docker Hub on release
  • Updates cagent to v1.23.4.

Changes

  • review-pr/agents/pr-review.yaml: Added welcome message and enhanced diff gathering to include PR metadata (title, body, author, files) for better context during reviews
  • review-pr/README.md: Updated "Running Locally" section with instructions for using the agent from Docker Hub via agentcatalog/review-pr
  • .github/workflows/release.yml: Added publish-agent job to push the review-pr agent to Docker Hub on release, including README upload
  • action.yml, review-pr/action.yml, .github/workflows/review-pr.yml: Updated default cagent version from v1.23.1 to v1.23.4
  • README.md: Updated documentation to reflect cagent v1.23.4 and clarified that extra-args passes to cagent run instead of cagent exec
  • action.yml: Changed command from cagent exec to cagent run --exec to align with updated cagent CLI

How to Test

  • Run cagent run agentcatalog/review-pr "Review my changes" from a local git repository to verify the agent diffs against the base branch and outputs review findings
  • Trigger a release workflow to verify the agent publishes successfully to Docker Hub
  • Test the PR review workflow on a pull request to ensure cagent v1.23.4 works correctly
Screen.recording.mp4

Closes: https://github.com/docker/gordon/issues/154

@derekmisler
Copy link
Contributor Author

/describe

@docker-agent
Copy link

docker-agent bot commented Feb 19, 2026

✅ PR description has been generated and updated!

@derekmisler derekmisler force-pushed the local-version-of-the-pr-reviewer branch from 5e7c62a to b7609d9 Compare February 19, 2026 17:52
@derekmisler
Copy link
Contributor Author

/describe

@docker-agent
Copy link

docker-agent bot commented Feb 19, 2026

✅ PR description has been generated and updated!

@derekmisler derekmisler force-pushed the local-version-of-the-pr-reviewer branch 3 times, most recently from ab94eba to c43c485 Compare February 19, 2026 18:21
@derekmisler derekmisler marked this pull request as ready for review February 19, 2026 18:22
@derekmisler derekmisler requested a review from a team as a code owner February 19, 2026 18:22
Copy link

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Found 3 potential issues in the new release workflow code that could affect the reliability of the Docker Hub publishing step. The main concerns are around error handling for the Docker Hub API interactions and a potential race condition with concurrent releases.

All issues are in added code and relate to the new publish-agent job. The rest of the changes (version updates, documentation changes, and agent instruction updates) look good.

@derekmisler derekmisler force-pushed the local-version-of-the-pr-reviewer branch 3 times, most recently from a4a07f2 to 8ee2f33 Compare February 19, 2026 18:39
@derekmisler
Copy link
Contributor Author

/review

Copy link

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Reviewed the changes for adding local PR reviewer support and Docker Hub publishing. Found 1 high-severity security issue in the release workflow that should be addressed.

Key Finding

  • Security: The cagent binary is downloaded and executed without checksum verification, which could allow code injection via MITM or compromised releases.

What looks good

  • The workflow properly validates secrets before use
  • Error handling with set -e is consistently applied
  • The PR reviewer agent improvements for local usage are well-structured
  • Version updates to v1.23.4 are consistent across files

@derekmisler
Copy link
Contributor Author

i know this PR is focused on running it locally, but i just love the output when running in CI: https://github.com/docker/cagent-action/actions/runs/22196041387

Signed-off-by: Derek Misler <derek.misler@docker.com>
@derekmisler derekmisler force-pushed the local-version-of-the-pr-reviewer branch from 8ee2f33 to aae9e8c Compare February 20, 2026 16:42
@derekmisler derekmisler merged commit 73c2715 into docker:main Feb 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants