Include telemetry tags so we can track usage of the action#42
Merged
derekmisler merged 1 commit intodocker:mainfrom Feb 13, 2026
Merged
Include telemetry tags so we can track usage of the action#42derekmisler merged 1 commit intodocker:mainfrom
derekmisler merged 1 commit intodocker:mainfrom
Conversation
Contributor
Author
|
/describe |
|
✅ PR description has been generated and updated! |
There was a problem hiding this comment.
Code Review Summary
✅ No issues found - The added telemetry tags are properly formatted and safe.
Review Details
I reviewed the addition of TELEMETRY_TAGS environment variable on line 429. The implementation correctly uses GitHub context variables (github.repository, github.workflow, github.run_id) in a comma-separated key=value format.
Security Analysis: GitHub enforces strict constraints on these context variables:
github.repository: Only alphanumeric characters, hyphens, and underscoresgithub.workflow: Can contain spaces, hyphens, underscores (no commas or equals signs)github.run_id: Always numeric
These constraints prevent any injection attacks or format-breaking characters, making the implementation safe as-is.
Recommendation: Approved - the code is correct and secure for its intended purpose.
Signed-off-by: Derek Misler <derek.misler@docker.com>
2f4e17e to
334c6b3
Compare
rumpl
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/docker/gordon/issues/121
Summary
Adds telemetry tags to the GitHub Action to enable tracking of action usage across repositories and workflows. The tags include source identifier, repository name, workflow name, and run ID.
Changes
TELEMETRY_TAGSenvironment variable with GitHub context values (repository, workflow, run_id) to track action usageBreaking Changes
None
How to Test