Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show summary of build warnings. #892

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

tonistiigi
Copy link
Member

In addition to showing warning where it happens show a summary after build has completed.

> docker buildx build .
...
 1 warning found (use --debug to expand):
 - Empty continuation line found in: RUN date &&     sleep 4 &&     date && echo $GREETING

with --debug

...
 1 warning found:
 - Empty continuation line found in: RUN date &&     sleep 4 &&     date && echo $GREETING
Empty continuation lines will become errors in a future release
More info: https://github.com/moby/moby/pull/33719
Dockerfile:11
--------------------
   9 |         sleep 4 && \
  10 |     
  11 | >>>     date && echo $GREETING
  12 |     RUN true
  13 |      
--------------------

Also fix the issue with progressbar and logging both printing to terminal at same time. Now logs are buffered while the terminal is active.

Additional commit suppresses some useless debug logs from vendored components.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi merged commit e482ba2 into docker:master Jan 4, 2022
@crazy-max crazy-max added this to the v0.8.0 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants