dockerconfig: add fallback for loading DHI and Scout credentials#3612
Merged
tonistiigi merged 1 commit intodocker:masterfrom Jan 16, 2026
Merged
dockerconfig: add fallback for loading DHI and Scout credentials#3612tonistiigi merged 1 commit intodocker:masterfrom
tonistiigi merged 1 commit intodocker:masterfrom
Conversation
crazy-max
previously approved these changes
Jan 16, 2026
These are also Docker managed registries with same users. Fall back to main hostname if not logged in to exact domain. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
jsternberg
approved these changes
Jan 16, 2026
| ) | ||
|
|
||
| const ( | ||
| dockerHubRegistryHost = "registry-1.docker.io" |
There was a problem hiding this comment.
Hi @tonistiigi @crazy-max @cdupuis, I just tried this new feature by using the associated released version v0.31.0 in the docker/setup-buildx-action. Out of curiosity, why it's registry-1.docker.io and not docker.io here?
Context: the default value for the registry in docker/login-action is docker.io.
Member
Author
There was a problem hiding this comment.
That's the actual hostname for main hub registry. https://docs.docker.com/reference/api/registry/latest/#tag/pull docker.io is redirect to docker.com if you send requests directly to that.
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are also Docker-managed registries with the same users.
Fall back to the main hostname if not logged in to the exact domain.
Note that this does not currently work with
imagetoolsas the auth system there has not yet been combined with new config loader from #3562 .@crazy-max @cdupuis