-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: print out the number of warnings after completing a rule check #2647
Conversation
a3d5c90
to
d9d78e5
Compare
d9d78e5
to
182a898
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have an integration test for both running check with and without warning to validate this?
182a898
to
e62143c
Compare
Added! |
@crazy-max @tonistiigi ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daghack Did you check the output of this for buildx bake
as well?
@tonistiigi Good catch. Will update! |
Yes another integration for bake would be ideal to make sure |
2f99242
to
eb4e3db
Compare
@crazy-max @tonistiigi Added matching integration checks for bake! :) |
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
eb4e3db
to
806ccd3
Compare
Atm when building with
--check
, when there are no warnings we generate the outputCheck completed, no warnings found.
When there are warnings, we leap right into displaying them.
This updates the output in the later case to contain a similar "Check completed" message which lists the warning count.