build: set same ref when building on multiple nodes #2572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when building with
bake
we are setting the build ref for each target which results with the same ref being set in solve request when building on multiple nodes:buildx/commands/bake.go
Lines 232 to 238 in 5656c98
But for
build
we don't do this in commands package and therefore it will generate a different one for each node:buildx/build/build.go
Line 229 in 5656c98
buildx/build/opt.go
Line 108 in 5656c98
@tonistiigi I think we should align
build
withbake
to have the same ref across nodes but let me know if this should be the other way around.cc @fiam