k8s: fix concurrent kubeconfig access when loading nodes #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
fix-k8s-kubeconfig
branch
from
bde91f0
to
2966370
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-k8s-kubeconfig
branch
from
2966370
to
945e774
Compare
3 tasks
|
@crazy-max I tested, and there are no issues. |
AkihiroSuda
reviewed
Jun 4, 2024
| name: test | ||
| current-context: test | ||
| name: k3s | ||
| current-context: k3s |
There was a problem hiding this comment.
I changed context to test if precedence matches expectations in the new test: https://github.com/docker/buildx/pull/2497/files#diff-bf08b5ea9b0c961aad5fc56bdec629b3cd9d42a21121839e0d5445a6effb4d92R22-R35
AkihiroSuda
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2436
Addresses a concurrency issue in the
ConfigFromEndpointfunction where multiple kubeconfig files were accessed simultaneously when loading nodes. This change ensures that kubeconfig files are accessed in a thread-safe manner by making config from the endpoint taking precedence, preventing potential race conditions.cc @gitfxx