k8s: opt to customize timeout during deployment #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnold Sobanski <arnold@l4g.dev>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
dvdksn
reviewed
Jun 3, 2024
| @@ -169,7 +174,7 @@ func TestFactory_processDriverOpts(t *testing.T) { | |||
| cfg.DriverOpts = map[string]string{ | |||
| "replicas": "invalid", | |||
| } | |||
| _, _, _, _, err := f.processDriverOpts(cfg.Name, "test", cfg) | |||
| _, _, _, _, _, err := f.processDriverOpts(cfg.Name, "test", cfg) | |||
There was a problem hiding this comment.
Yes we need to review processDriverOpts func 🙈
AkihiroSuda
approved these changes
Jun 3, 2024
ali-kafel
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2457
closes #2472
carry #2457 with some changes to rename
provisioningTimeouttotimeoutand also remove the attribute from deployment manifest that is not actually used.needs docs follow-up in: https://docs.docker.com/build/drivers/kubernetes/ (cc @dvdksn)
test: https://github.com/docker/buildx/actions/runs/9346931610/job/25722907636?pr=2492#step:9:19
cc @Arsobbiak @ali-kafel