Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update compose-go to v1.19.0 #2065

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Sep 29, 2023

Signed-off-by: David Karlsson 35727626+dvdksn@users.noreply.github.com

Bake is currently broken for projects with a compose.yaml that implements the latest version of the compose spec (the one used by Docker Compose v1.22)

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@crazy-max
Copy link
Member

crazy-max commented Sep 30, 2023

Can we have a test similar to b01693f?

I think in this is case we want to test the develop section: compose-spec/compose-go#461

Also not for this PR but as discussed, to avoid having the same kind of issue in the future maybe we should be less strict and only care about what's necessary to build with bake. But relaxing schema validation can be tricky.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member

Added extra commit to test with develop section.

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @glours

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , Thanks @dvdksn 🙏

@crazy-max crazy-max merged commit 561a433 into docker:master Oct 3, 2023
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants