-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bearer token support #1891
Add Bearer token support #1891
Conversation
Signed-off-by: Dmitry Makovey <dmakovey@gitlab.com>
pipeline failure seems to be unrelated to the changes and intermittent. There's no way for me to re-run the job. |
inspired by docker/cli#2540 |
@tonistiigi would you mind taking a look at this? |
@AkihiroSuda 🏓 ☝️ |
@droopy4096 Needs docs update in follow-up if you can do it 🙏 |
thanks @crazy-max will see what can be added... However since this PR did not introduced any new functionality and rather fixed what was expected to work I'm not certain what should be documented. |
My bad! No functional changes indeed. |
Investigating #1884 it turned out that Bearer token is not being passed along from config file, resulting in described issues. This PR adds Bearer Token support for authentication.
This fix was tested with GitLab Kubernetes Agent Server successfully.