Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bearer token support #1891

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Add Bearer token support #1891

merged 1 commit into from
Jul 12, 2023

Conversation

droopy4096
Copy link
Contributor

@droopy4096 droopy4096 commented Jun 16, 2023

Investigating #1884 it turned out that Bearer token is not being passed along from config file, resulting in described issues. This PR adds Bearer Token support for authentication.

This fix was tested with GitLab Kubernetes Agent Server successfully.

Signed-off-by: Dmitry Makovey <dmakovey@gitlab.com>
@droopy4096
Copy link
Contributor Author

pipeline failure seems to be unrelated to the changes and intermittent. There's no way for me to re-run the job.

@droopy4096
Copy link
Contributor Author

inspired by docker/cli#2540

@droopy4096
Copy link
Contributor Author

@tonistiigi would you mind taking a look at this?

@droopy4096
Copy link
Contributor Author

@AkihiroSuda 🏓 ☝️

@tonistiigi tonistiigi merged commit 6942118 into docker:master Jul 12, 2023
@crazy-max
Copy link
Member

crazy-max commented Jul 12, 2023

@droopy4096
Copy link
Contributor Author

@droopy4096 Needs docs update in follow-up if you can do it pray

* https://github.com/docker/buildx/blob/master/docs/reference/buildx_create.md#kubernetes-driver-1

* https://github.com/docker/docs/blob/main/build/drivers/kubernetes.md

thanks @crazy-max will see what can be added... However since this PR did not introduced any new functionality and rather fixed what was expected to work I'm not certain what should be documented.

@crazy-max
Copy link
Member

thanks @crazy-max will see what can be added... However since this PR did not introduced any new functionality and rather fixed what was expected to work I'm not certain what should be documented.

My bad! No functional changes indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants