imagetools: use docker/cli formatting #1882
Draft
+13,077
−310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thaJeztah, this isn't finished but I thought it would be good to create a draft PR for some early feedback. I was initially just going to fix the formatting directive, but thought it would be nicer to make use of github.com/docker/cli/cli/command/inspect and github.com/docker/cli/cli/command/formatter. Using the formatting package should result in a lot less duplicate code, and would be consistent with What are your thoughts? |
Use the formatting packages provided by docker/cli to comply with the official formatting documentation. https://docs.docker.com/config/formatting/ The use of the official formatting packages also fixes the format templating. Fixes: docker#1175 Signed-off-by: Thomas Way <thomas@6f.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the formatting packages provided by docker/cli to comply with the official formatting documentation.
https://docs.docker.com/config/formatting/
The use of the official formatting packages also fixes the format templating.
Fixes: #1175