monitor: Allow launching container from non-exec op with on-error
#1807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following-up #1640 (comment) :
From @jedevc 's comment:
Currently
on-error
launches container only from the errored ExecOp. This commit allows it from FileOp (COPY instruction) as well.Unfortunately buildkitd doesn't seem to return the container execution information (
*pb.Meta
) on non-exec op failure, so we lanch the container from the result of the previous op of the failed one. Currently this is supported only for FileOp but we can expand this feature for other types of Ops if needed in the future.In the following example Dockerfile, the build fails on
COPY --from=dev /none /
and the debugger container is created by the result of the input (COPY --from=dev /hi /
).