Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guide): color output controls #1230

Merged
merged 1 commit into from
Jul 23, 2022

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Jul 23, 2022

follow-up #1226

behavior lgtm:

image

image

but looks like the example in README of BuildKit repo is not correct:

$ BUILDKIT_COLORS="run=blue;cancel=yellow;warn=orange;error=123,12,0" docker buildx bake
WARN[0000] Could not parse BUILDKIT_COLORS component: run=blue;cancel=yellow;warn=orange;error=123,12,0  error="A valid entry must have exactly two fields"

should be run=blue:cancel=yellow:warn=orange:error=123,12,0 as correct separator but then:

$ BUILDKIT_COLORS="run=blue:cancel=yellow:warn=orange:error=123,12,0" docker buildx bake
WARN[0000] Unknown color value found in BUILDKIT_COLORS: warn=orange  error="Colors must be a name from the pre-defined list or a valid 3-part RGB value"

orange does not exist in pre-defined colors.

cc @spkane

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max merged commit 97d3841 into docker:master Jul 23, 2022
@crazy-max crazy-max deleted the docs-color-ouput branch July 23, 2022 10:29
@spkane
Copy link
Contributor

spkane commented Jul 23, 2022

@crazy-max Thank you for catching that. It was a last-minute change to the PR that removed the named orange color since it is not a standard 4-bit color like the other named colors. I'll also update the separator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants