Mono action #87

crazy-max · 2020-08-11T09:02:47Z

Ref. #71

`setup-buildx`

This actions allows to set up Docker Buildx. It's written as a typescript-action to be as closed as possible of the GitHub Runner during its execution.

Allow to choose buildx version (default to the one installed on the runner)
Allow to install buildx by default
Set builder name to allow isolated builder instances
Add driver input. Default to docker-container
Add driver-opt input.
Add use input. Default true
Output available platforms
Documentation with examples
Tests and/or CI workflows

`setup-qemu`

This action allows to install QEMU static binaries. It's written as a typescript-action to be as closed as possible of the GitHub Runner during its execution.

QEMU static binaries Docker image. Default to tonistiigi/binfmt:latest for now.
Platforms to install. Default to all.
Output available platforms
Use it with setup-buildx action
Documentation with examples
Tests and/or CI workflows

`build-push`

Will be made in a further PR

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

crazy-max · 2020-08-11T13:00:54Z

@tonistiigi Wonder if "Opt-in to buildkit for all docker build commands" is really necessary because buildx will always build using the BuildKit engine and does not require DOCKER_BUILDKIT=1 environment variable for starting builds.

setup-buildx/.editorconfig

setup-buildx/README.md

setup-buildx/src/main.ts

setup-qemu/src/main.ts

setup-qemu/README.md

setup-buildx/src/installer.ts

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Add platforms input to choose what platforms to install Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

.github/workflows/setup-qemu-ci.yml

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Use default buildx on runner Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

setup-buildx/src/main.ts

tonistiigi · 2020-08-13T07:04:19Z

setup-buildx/src/main.ts

+async function run(): Promise<void> {
+  try {
+    if (os.platform() !== 'linux') {
+      core.setFailed('Only supported on linux platform');


Not sure if this is a good idea but we do have mac and windows releases of buildx. It would not work by default though but with a remote endpoint. Thinking about that, maybe we should support remote endpoint, but don't have a good flow in mind atm. Maybe option that allows skipping "create" step so create can be run inside workflow with custom endpoint configuration.

I don't think that adding support for platforms other than Linux is paramount as it stands, especially since Docker is not installed on MacOS virtual environments.

Yeah, not that important. Buildx does work without a docker binary as well though.

setup-qemu/.gitattributes

setup-qemu/README.md

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

crazy-max requested review from justincormack, tonistiigi and chris-crone August 11, 2020 09:02

crazy-max self-assigned this Aug 11, 2020

This was referenced Aug 11, 2020

Mono action #86

Closed

v2: upgrade to buildx #71

Closed

crazy-max added 8 commits August 11, 2020 14:33

Add setup-buildx action (#71)

6df1822

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Fix setup-buildx test workflow

36c90bc

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Add setup-qemu action (#71)

64d53ac

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Add qemu + buildx job

87d5297

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Example with QEMU

f443d57

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Will be named docker/actions

925fee3

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Add install input to set buildx as default builder (#71)

5290010

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Update README

8d34fc9

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

crazy-max force-pushed the mono-action branch from d5a262d to 8d34fc9 Compare August 11, 2020 12:34

tonistiigi reviewed Aug 11, 2020

View reviewed changes

crazy-max added 2 commits August 11, 2020 21:05

Move editorconfig

7e439a0

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Switch to tonistiigi/binfmt

b943609

Add platforms input to choose what platforms to install Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

tonistiigi reviewed Aug 11, 2020

View reviewed changes

.github/workflows/setup-qemu-ci.yml Outdated Show resolved Hide resolved

crazy-max added 10 commits August 11, 2020 21:53

Fix workflows

e3626b5

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Use master tag

66ba91a

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Update READMEs

a1eb172

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Dump contexts for testing purpose

3f39bb9

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Trigger on master branch

674ff6a

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Output available platforms for setup-qemu

2f906a9

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Generated content

2ad38f5

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Dump context composite

4522dd9

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Fix platforms extraction

1886d93

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Silent command

8e7bb4a

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

crazy-max added 6 commits August 12, 2020 14:10

Fix workflow

d0f7649

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Add 'use' input

15c6a86

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Check if buildx available on runner

5bb3f54

Use default buildx on runner Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Update workflow

1ef5714

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Update workflow

b72149b

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Add name output to identify builder instance name

0cc5e42

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

crazy-max requested a review from tonistiigi August 12, 2020 18:33

crazy-max added 4 commits August 12, 2020 21:34

Update README

ec2628b

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Small refactor

26b3a3b

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Update generated content

e53a3da

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Improve stateHelper

c3b8f61

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

tonistiigi reviewed Aug 13, 2020

View reviewed changes

crazy-max added 2 commits August 13, 2020 10:42

Rename buildx-version input to version

8f0f662

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Update generated content

46bf329

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

crazy-max requested a review from tonistiigi August 13, 2020 08:58

tonistiigi approved these changes Aug 14, 2020

View reviewed changes

crazy-max added 2 commits August 14, 2020 19:49

Display available platforms

ee3946b

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

Temp branch event trigger for our tests on v2 actions

33f14d6

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

crazy-max changed the base branch from master to mig August 14, 2020 17:56

crazy-max changed the base branch from mig to v2-working-branch August 14, 2020 17:59

Switch working branch

4e201a2

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

crazy-max requested a review from tonistiigi August 14, 2020 18:02

tonistiigi approved these changes Aug 14, 2020

View reviewed changes

tonistiigi merged commit 3f08c86 into v2-working-branch Aug 14, 2020

crazy-max deleted the mono-action branch August 14, 2020 18:03

crazy-max added a commit to docker/setup-buildx-action that referenced this pull request Aug 18, 2020

Initial commit (docker/build-push-action#87)

04eaa7c

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

crazy-max mentioned this pull request Aug 18, 2020

First release docker/setup-buildx-action#1

Merged

5 tasks

crazy-max added a commit to docker/setup-qemu-action that referenced this pull request Aug 18, 2020

Initial commit (docker/build-push-action#87)

0b8d326

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

crazy-max mentioned this pull request Aug 18, 2020

First release docker/setup-qemu-action#1

Merged

2 tasks

crazy-max added this to the v2 milestone Sep 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mono action #87

Mono action #87

crazy-max commented Aug 11, 2020 •

edited

Loading

crazy-max commented Aug 11, 2020

tonistiigi Aug 13, 2020

crazy-max Aug 13, 2020

tonistiigi Aug 14, 2020

Mono action #87

Mono action #87

Conversation

crazy-max commented Aug 11, 2020 • edited Loading

setup-buildx

setup-qemu

build-push

crazy-max commented Aug 11, 2020

tonistiigi Aug 13, 2020

Choose a reason for hiding this comment

crazy-max Aug 13, 2020

Choose a reason for hiding this comment

tonistiigi Aug 14, 2020

Choose a reason for hiding this comment

crazy-max commented Aug 11, 2020 •

edited

Loading

`setup-buildx`

`setup-qemu`

`build-push`