Simplified and unified argument collection #430
+39
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearphage
force-pushed
the
argument-collection
branch
from
7a80bb2 to
f12c810
Compare
|
@crazy-max Thoughts? Concerns? Suggestions? |
|
Needs rebase. |
fearphage
force-pushed
the
argument-collection
branch
from
82fca7e to
81f2236
Compare
|
@crazy-max Rebased. |
|
@crazy-max I think I figured it out this time. |
Signed-off-by: Phred <fearphage@gmail.com>
Signed-off-by: Phred <fearphage@gmail.com>
Signed-off-by: Phred <fearphage@gmail.com>
Signed-off-by: Phred <fearphage@gmail.com>
fearphage
force-pushed
the
argument-collection
branch
from
b087ae4 to
d936484
Compare
|
@crazy-max Another time around the bin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's it. Just a bit of clean up.