This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Fix docker-app save on single-file application
#352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-crone
suggested changes
Aug 22, 2018
internal/packager/registry.go
Outdated
| df := filepath.Join(app.Path, "__Dockerfile-docker-app__") | ||
| dir, err := ioutil.TempDir("", app.Name) | ||
| if err != nil { | ||
| return "", errors.Wrap(err, "cannot create temporary directoryr") |
vdemeester
force-pushed
the
351-fix-save
branch
from
a9f780e
to
2bd75af
Compare
mnottale
reviewed
Aug 22, 2018
types/types.go
Outdated
| @@ -39,6 +39,19 @@ func (a *App) Metadata() []byte { | |||
| return a.metadataContent | |||
| } | |||
|
|
|||
| func (a *App) Extract(path string) error { | |||
There was a problem hiding this comment.
Lint error, missing method doc.
mnottale
reviewed
Aug 22, 2018
types/types.go
Outdated
| @@ -39,6 +39,19 @@ func (a *App) Metadata() []byte { | |||
| return a.metadataContent | |||
| } | |||
|
|
|||
| func (a *App) Extract(path string) error { | |||
| if err := ioutil.WriteFile(filepath.Join(path, internal.MetadataFileName), a.Metadata(), 0755); err != nil { | |||
There was a problem hiding this comment.
nit: mode should rather be 0644, no need for exec bit
vdemeester
force-pushed
the
351-fix-save
branch
2 times, most recently
from
fe4e1c6
to
0dac7a6
Compare
chris-crone
approved these changes
Aug 22, 2018
vdemeester
force-pushed
the
351-fix-save
branch
from
0dac7a6
to
f96d6c8
Compare
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
351-fix-save
branch
from
f96d6c8
to
a8a9779
Compare
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
==========================================
- Coverage 58.6% 58.42% -0.18%
==========================================
Files 56 56
Lines 2802 2819 +17
==========================================
+ Hits 1642 1647 +5
- Misses 939 945 +6
- Partials 221 227 +6
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #351
0.4.1release 👼Signed-off-by: Vincent Demeester vincent@sbr.pm