Merge pull request #154 from crazy-max/docker-install-stop

docker(install): stop docker daemon gracefully on linux
docker · Aug 26, 2023 · c674e72 · c674e72
2 parents 6a8f167 + a72977c
commit c674e72
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/src/docker/assets.ts b/src/docker/assets.ts
@@ -72,6 +72,7 @@ mkdir -p "$RUNDIR"
   echo "Starting dockerd"
   set -x
   exec dockerd \\
+    --debug \\
     --host="$DOCKER_HOST" \\
     --exec-root="$RUNDIR/execroot" \\
     --data-root="$RUNDIR/data" \\

diff --git a/src/docker/install.ts b/src/docker/install.ts
@@ -311,13 +311,17 @@ export class Install {
       core.info(fs.readFileSync(path.join(this.runDir, 'dockerd.log'), {encoding: 'utf8'}));
     });
     await core.group('Stopping Docker daemon', async () => {
-      await Exec.exec('sudo', ['kill', fs.readFileSync(path.join(this.runDir, 'docker.pid')).toString().trim()]);
+      await Exec.exec('sudo', ['kill', '-s', 'SIGTERM', fs.readFileSync(path.join(this.runDir, 'docker.pid')).toString().trim()]);
+      await Util.sleep(5);
     });
     await core.group('Removing Docker context', async () => {
       await Exec.exec('docker', ['context', 'rm', '-f', this.contextName]);
     });
     await core.group(`Cleaning up runDir`, async () => {
-      await Exec.exec('sudo', ['rm', '-rf', this.runDir]);
+      await Exec.exec('sudo', ['rm', '-rf', this.runDir], {
+        ignoreReturnCode: true,
+        failOnStdErr: false
+      });
     });
   }
 

diff --git a/src/util.ts b/src/util.ts
@@ -133,4 +133,8 @@ export class Util {
     }
     return str.substring(0, index);
   }
+
+  public static sleep(seconds: number) {
+    return new Promise(resolve => setTimeout(resolve, seconds * 1000));
+  }
 }