Only chown things in the entrypoint that are not already owned by redmine #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mine Also only chmod when not the right permissions
This was referenced Sep 25, 2018
Merged
tianon
approved these changes
Sep 28, 2018
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Oct 1, 2018
- `busybox`: 1.29.3, Buildroot 2018.08, Alpine 3.8 - `cassandra`: fix `cassandra.yaml` modification (docker-library/cassandra#160), `chown` fixes (docker-library/cassandra#158) - `ghost`: `chown` fixes (docker-library/ghost#153) - `julia`: 1.0.1 - `mariadb`: `chown` fixes (MariaDB/mariadb-docker#203) - `mongo`: `chown` fixes (docker-library/mongo#305) - `openjdk`: Oracle variants (docker-library/openjdk#235), 11 GA - `owncloud`: `chown` fixes (docker-library/owncloud#105) - `percona`: `chown` fixes (docker-library/percona#69) - `php`: 7.3.0RC2 - `rabbitmq`: `chown` fixes (docker-library/rabbitmq#281) - `redis`: `chown` fixes (redis/docker-library-redis#166) - `redmine`: `chown` fixes (docker-library/redmine#128) - `ruby`: Alpine thread stack size fix (docker-library/ruby#237) - `tomcat`: add JRE 11, remove EOL Tomcat 8.0 (docker-library/tomcat#133)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also only
chmodwhen not it is not the right permissions. This removes theugo-x,u+rwX,go+rX,go-w, which makes it much easier to understand.This does not change the
chownto user only like the mariadb and percona changes do since the upstream docs recommendchown redmine:redmine. Should I expand the finds to fix group owner too?Same as docker-library/rabbitmq#281, MariaDB/mariadb-docker#203, docker-library/percona#69