Pin pip to 20.x (the last version to support Python 2) #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It makes sense to stick them to the same for now. Users can update pip in their own Dockerfile and we can always revisit whether or not to update pip in |
yosifkit
approved these changes
Jan 28, 2021
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 28, 2021
Changes: - docker-library/pypy@60e28bf: Merge pull request docker-library/pypy#51 from infosiftr/pip-20 - docker-library/pypy@9625e09: Pin pip to 20.x (the last version to support Python 2) - docker-library/pypy@0cedf2f: Update to 7.3.3, pip 20.3.3
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 28, 2021
Changes: - docker-library/pypy@60e28bf: Merge pull request docker-library/pypy#51 from infosiftr/pip-20 - docker-library/pypy@9625e09: Pin pip to 20.x (the last version to support Python 2) - docker-library/pypy@0cedf2f: Update to 7.3.3, pip 20.3.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure this is the "right" solution, but we have the very real situation where pip 21.x has been released which drops Python 2 support, but PyPy is still actively supporting their Python 2 variant (for the foreseeable future), and IMO it would be strange for us to ship pip 21.x for
pypy:3and pip 20.x forpypy:2when they're actually part of the same PyPy release (not separate release lines, like in upstream Python).