Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly enable "mbstring" by default (since certain pecl bits cannot work properly otherwise) #211

Merged
merged 1 commit into from
Mar 30, 2016

Conversation

tianon
Copy link
Member

@tianon tianon commented Mar 30, 2016

Fixes #34
Fixes #195

@yosifkit
Copy link
Member

LGTM

@yosifkit yosifkit merged commit fb53da7 into docker-library:master Mar 30, 2016
@yosifkit yosifkit deleted the mbstring branch March 30, 2016 21:07
@bizmate
Copy link

bizmate commented Mar 30, 2016

@tianon thanks for changing this, i tried 6 hours ago to install mbstring and it looks like it was working https://hub.docker.com/r/diegogullo/php_docker_56/ -> https://github.com/bizmate/php_docker_56/blob/master/Dockerfile#L14

Maybe after all it is not needed by default? I can see it enabled in this image and it works fine. Initially in the debian box i could not see a way to install it but using the line above it looks alright

@yosifkit
Copy link
Member

Yeah, it could be installed after, but as far as I know pecl can't use it unless it is built in to php (#195 (comment))

@bizmate
Copy link

bizmate commented Mar 31, 2016

Thanks for point that out explicitly, i totally skipped that part. Still I dont see the images being updated on docker hub. Arent they auto-built?

@yosifkit
Copy link
Member

yosifkit commented Apr 1, 2016

We don't use hub autobuilds. Our process goes through https://github.com/docker-library/official-images for repeatable builds that utilize docker build caching. @tianon is working on the PR to update a bunch of them, but the images probably won't show up until tomorrow morning.

tianon added a commit to infosiftr/stackbrew that referenced this pull request Apr 4, 2016
- `django`: 1.9.5
- `docker`: 1.11.0-rc3, add tune2fs and mkfs.xfs (docker-library/docker#10)
- `elasticsearch`: 2.3.1
- `golang`: force-enable `-fno-PIC` in Alpine (docker-library/golang#91)
- `irssi`: 0.8.19 (jessfraz/irssi#6), add Alpine variant (jessfraz/irssi#7)
- `java`: 9~b112-2 (still fails to build), Alpine to 8.77.03-r0 (8u77), fix Alpine tags to reference the proper version
- `julia`: 0.4.5
- `mariadb`: 10.1.13+maria-1~jessie
- `mongo`: 3.0.11
- `mysql`: `ENTRYPOINT` consistency (`docker-entrypoint.sh` with a compatibility symlink)
- `owncloud`: add `exif` module (docker-library/owncloud#53)
- `php`: 7.0.5, 5.6.20, 5.5.34, always enable `mbstring` (docker-library/php#211)
- `postgres`: 9.5.2-1.pgdg80+1, 9.4.7-1.pgdg80+1, 9.3.12-1.pgdg80+1, 9.2.16-1.pgdg80+1, 9.1.21-1.pgdg80+1, local interfaces during init (docker-library/postgres#136)
- `pypy`: 5.0.1
- `python`: fix `python-config` symlink (docker-library/python#99)
- `rocket.chat`: 0.24.0
- `ruby`: 2.1.9, switch `libedit` to `readline` for `irb` (docker-library/ruby#76)
RichardScothern pushed a commit to RichardScothern/official-images that referenced this pull request Jun 14, 2016
- `django`: 1.9.5
- `docker`: 1.11.0-rc3, add tune2fs and mkfs.xfs (docker-library/docker#10)
- `elasticsearch`: 2.3.1
- `golang`: force-enable `-fno-PIC` in Alpine (docker-library/golang#91)
- `irssi`: 0.8.19 (jessfraz/irssi#6), add Alpine variant (jessfraz/irssi#7)
- `java`: 9~b112-2 (still fails to build), Alpine to 8.77.03-r0 (8u77), fix Alpine tags to reference the proper version
- `julia`: 0.4.5
- `mariadb`: 10.1.13+maria-1~jessie
- `mongo`: 3.0.11
- `mysql`: `ENTRYPOINT` consistency (`docker-entrypoint.sh` with a compatibility symlink)
- `owncloud`: add `exif` module (docker-library/owncloud#53)
- `php`: 7.0.5, 5.6.20, 5.5.34, always enable `mbstring` (docker-library/php#211)
- `postgres`: 9.5.2-1.pgdg80+1, 9.4.7-1.pgdg80+1, 9.3.12-1.pgdg80+1, 9.2.16-1.pgdg80+1, 9.1.21-1.pgdg80+1, local interfaces during init (docker-library/postgres#136)
- `pypy`: 5.0.1
- `python`: fix `python-config` symlink (docker-library/python#99)
- `rocket.chat`: 0.24.0
- `ruby`: 2.1.9, switch `libedit` to `readline` for `irb` (docker-library/ruby#76)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants