Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rakudo-star $PATH #9100

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Fix rakudo-star $PATH #9100

merged 1 commit into from
Nov 17, 2020

Conversation

m-dango
Copy link
Contributor

@m-dango m-dango commented Nov 16, 2020

The paths for some key binaries are currently missing from $PATH. The PR rakudo/docker#36 was created and merged to address this issue.

Closes rakudo/docker#37.

@github-actions
Copy link

Diff for a1813fc:

@yosifkit
Copy link
Member

Diff:
diff --git a/_bashbrew-cat b/_bashbrew-cat
index 72f229c..d29c9d2 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -3,10 +3,10 @@ GitRepo: https://github.com/Raku/docker
 
 Tags: alpine, 2020.10-alpine
 Architectures: amd64, arm64v8
-GitCommit: 0d86b9c4575d22574c43356fb5773c33ae96c6eb
+GitCommit: 9101edf7704759d30c6fd180f3f9646109e1327d
 Directory: 2020.10/alpine3.12
 
 Tags: latest, 2020.10
 Architectures: amd64, arm64v8
-GitCommit: 0d86b9c4575d22574c43356fb5773c33ae96c6eb
+GitCommit: 9101edf7704759d30c6fd180f3f9646109e1327d
 Directory: 2020.10/buster
diff --git a/rakudo-star_2020.10-alpine/Dockerfile b/rakudo-star_2020.10-alpine/Dockerfile
index 2aa1c86..b6af975 100644
--- a/rakudo-star_2020.10-alpine/Dockerfile
+++ b/rakudo-star_2020.10-alpine/Dockerfile
@@ -36,6 +36,6 @@ RUN buildDeps=' \
     && rm -rf $tmpdir \
     && apk del --no-network .build-deps
 
-ENV PATH=$PATH:/usr/share/perl6/site/bin
+ENV PATH=$PATH:/usr/share/perl6/core/bin:/usr/share/perl6/site/bin:/usr/share/perl6/vendor/bin
 
 CMD ["raku"]
diff --git a/rakudo-star_2020.10/Dockerfile b/rakudo-star_2020.10/Dockerfile
index bf02d2f..5cd80b1 100644
--- a/rakudo-star_2020.10/Dockerfile
+++ b/rakudo-star_2020.10/Dockerfile
@@ -36,6 +36,6 @@ RUN buildDeps=' \
     && rm -rf $tmpdir \
     && apt-get purge -y --auto-remove $buildDeps
 
-ENV PATH=$PATH:/usr/share/perl6/site/bin
+ENV PATH=$PATH:/usr/share/perl6/core/bin:/usr/share/perl6/site/bin:/usr/share/perl6/vendor/bin
 
 CMD ["raku"]

@yosifkit
Copy link
Member

LGTM
cc listed maintainer: @moritz

@moritz
Copy link
Contributor

moritz commented Nov 17, 2020

Looks good to me as well 👍

@tianon tianon merged commit 48a5d00 into docker-library:master Nov 17, 2020
@m-dango m-dango deleted the raku-path branch November 17, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push new 2020.10 image to docker hub
4 participants