Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release rethinkdb 2.4.1 #8551

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Release rethinkdb 2.4.1 #8551

merged 2 commits into from
Aug 14, 2020

Conversation

gabor-boros
Copy link
Contributor

Hello,

We would like to push our new version 2.4.1 to docker hub.

@github-actions
Copy link

Diff for 3b09799:
diff --git a/_bashbrew-cat b/_bashbrew-cat
index 5db27cf..412647e 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -1,10 +1,18 @@
 Maintainers: RethinkDB <services@rethinkdb.com> (@gabor-boros)
 GitRepo: https://github.com/rethinkdb/rethinkdb-dockerfiles.git
 
-Tags: 2.4.0-buster-slim, 2.4-buster-slim, 2-buster-slim, buster-slim, 2.4.0, 2.4, 2, latest
+Tags: 2.4.0-buster-slim, 2.4.0
 GitCommit: 444f7754822cb3e96cb2b66042d8e87d2227be0b
 Directory: buster/2.4.0
 
-Tags: 2.4.0-centos, 2.4-centos, 2-centos, centos
+Tags: 2.4.0-centos
 GitCommit: 444f7754822cb3e96cb2b66042d8e87d2227be0b
 Directory: centos8/2.4.0
+
+Tags: 2.4.1-buster-slim, 2.4-buster-slim, 2-buster-slim, buster-slim, 2.4.1, 2.4, 2, latest
+GitCommit: 5bccd499742f6f05e7ddc970842a1763bdd99cfa
+Directory: buster/2.4.1
+
+Tags: 2.4.1-centos, 2.4-centos, 2-centos, centos
+GitCommit: 5bccd499742f6f05e7ddc970842a1763bdd99cfa
+Directory: centos8/2.4.1
diff --git a/_bashbrew-list b/_bashbrew-list
index 2d9e02e..3247680 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -7,6 +7,9 @@ rethinkdb:2.4-centos
 rethinkdb:2.4.0
 rethinkdb:2.4.0-buster-slim
 rethinkdb:2.4.0-centos
+rethinkdb:2.4.1
+rethinkdb:2.4.1-buster-slim
+rethinkdb:2.4.1-centos
 rethinkdb:buster-slim
 rethinkdb:centos
 rethinkdb:latest
diff --git a/rethinkdb_centos/Dockerfile b/rethinkdb_2.4.0-centos/Dockerfile
similarity index 100%
copy from rethinkdb_centos/Dockerfile
copy to rethinkdb_2.4.0-centos/Dockerfile
diff --git a/rethinkdb_latest/Dockerfile b/rethinkdb_2.4.0/Dockerfile
similarity index 100%
copy from rethinkdb_latest/Dockerfile
copy to rethinkdb_2.4.0/Dockerfile
diff --git a/rethinkdb_centos/Dockerfile b/rethinkdb_centos/Dockerfile
index b21d058..405b76a 100644
--- a/rethinkdb_centos/Dockerfile
+++ b/rethinkdb_centos/Dockerfile
@@ -1,6 +1,6 @@
 FROM centos:8
 
-ENV RETHINKDB_PACKAGE_VERSION 2.4.0
+ENV RETHINKDB_PACKAGE_VERSION 2.4.1
 
 RUN echo $'[rethinkdb]\n\
 name=RethinkDB\n\
diff --git a/rethinkdb_latest/Dockerfile b/rethinkdb_latest/Dockerfile
index d95712b..cc6cce8 100644
--- a/rethinkdb_latest/Dockerfile
+++ b/rethinkdb_latest/Dockerfile
@@ -4,10 +4,10 @@ RUN apt-get -qqy update \
     && apt-get install -y --no-install-recommends ca-certificates gnupg2 \
     && rm -rf /var/lib/apt/lists/*
 
-RUN apt-key adv --keyserver keys.gnupg.net --recv-keys "539A 3A8C 6692 E6E3 F69B 3FE8 1D85 E93F 801B B43F" \
+RUN apt-key adv --keyserver keys.gnupg.net --recv-keys "539A3A8C6692E6E3F69B3FE81D85E93F801BB43F" \
     && echo "deb https://download.rethinkdb.com/repository/debian-buster buster main" > /etc/apt/sources.list.d/rethinkdb.list
 
-ENV RETHINKDB_PACKAGE_VERSION 2.4.0~0buster
+ENV RETHINKDB_PACKAGE_VERSION 2.4.1~0buster
 
 RUN apt-get -qqy update \
 	&& apt-get install -y rethinkdb=$RETHINKDB_PACKAGE_VERSION \

@gabor-boros
Copy link
Contributor Author

gabor-boros commented Aug 14, 2020

Could you please restart the failing build? The issue was on the download server and fixed now.

@yosifkit yosifkit merged commit aead700 into docker-library:master Aug 14, 2020
Directory: centos8/2.4.1
GitCommit: 5bccd499742f6f05e7ddc970842a1763bdd99cfa

Tags: 2.4.0-buster-slim, 2.4.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to keep this version listed here? Removing tags here will remove them from the "Supported" section on the Hub readme (and will prevent us from spending cycles rebuilding them on the official build servers), but the tags will still be available to users who want them. (See https://github.com/docker-library/official-images#library-definition-files for more detail on this.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friendly ping 😉 ❤️

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabor-boros Not sure if you saw this comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marchaos Sorry I clearly missed this comment.

@tianon I made a task for myself for the next week to open a PR removing those tags.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Sorry, I totally missed this one! I'll be back in ~2 weeks and check it for sure!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR: I didn't forget this issue!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame on me @tianon, the PR is: #11149

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all good -- thanks for getting back to it! 😄 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants