-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Lightstreamer image due to hotfix #7377
Conversation
Diff:diff --git a/lightstreamer_7-jdk8/Dockerfile b/lightstreamer_7-jdk8/Dockerfile
index 393e531..9053509 100644
--- a/lightstreamer_7-jdk8/Dockerfile
+++ b/lightstreamer_7-jdk8/Dockerfile
@@ -2,6 +2,7 @@
FROM openjdk:8-jdk
LABEL maintainer="Lightstreamer Server Development Team <support@lightstreamer.com>"
+LABEL build="1951"
# Import Lighstreamer's public key
RUN gpg --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys 9B90BFD14309C7DA5EF58D7D4A8C08966F29B4D2
@@ -30,7 +31,7 @@ RUN set -ex; \
# Add new user and group
&& groupadd -r -g 10000 lightstreamer \
&& useradd --no-log-init -r -g lightstreamer -u 10000 lightstreamer \
-# Change ownership of tye lightstreamer folder
+# Change ownership of the lightstreamer folder
&& chown -R lightstreamer:lightstreamer ../lightstreamer \
# Finally, remove no longer needed files
&& rm Lightstreamer.tar.gz Lightstreamer.tar.gz.asc
diff --git a/lightstreamer_latest/Dockerfile b/lightstreamer_latest/Dockerfile
index e3b8bf5..fecdae0 100644
--- a/lightstreamer_latest/Dockerfile
+++ b/lightstreamer_latest/Dockerfile
@@ -2,6 +2,7 @@
FROM openjdk:11-jdk
LABEL maintainer="Lightstreamer Server Development Team <support@lightstreamer.com>"
+LABEL build="1951"
# Import Lighstreamer's public key
RUN gpg --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys 9B90BFD14309C7DA5EF58D7D4A8C08966F29B4D2
@@ -30,7 +31,7 @@ RUN set -ex; \
# Add new user and group
&& groupadd -r -g 10000 lightstreamer \
&& useradd --no-log-init -r -g lightstreamer -u 10000 lightstreamer \
-# Change ownership of tye lightstreamer folder
+# Change ownership of the lightstreamer folder
&& chown -R lightstreamer:lightstreamer ../lightstreamer \
# Finally, remove no longer needed files
&& rm Lightstreamer.tar.gz Lightstreamer.tar.gz.asc |
What's the goal of this PR? What is this new See also #3540 (comment), especially:
If the goal is to have a point to force an image rebuild, we should just update the |
I'm sorry but It is not clear to me the workflow: how can I trigger an update of the |
If you look at https://hub.docker.com/_/lightstreamer?tab=tags, you can see that it already happened ~3 days ago. 😄 |
Oh, cool! Could you expand please more on this? Is there any link you can point me out which explains how and when already published images get rebuilt? |
Sure, the primary reference is https://github.com/docker-library/official-images#library-definition-files:
It's also referenced at https://github.com/docker-library/faq#why-does-my-security-scanner-show-that-an-image-has-cves (with a link back to that primary reference):
|
Ok, thank you very much. |
No description provided.