Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Couchbase Server Official Docker image. #729

Merged
merged 3 commits into from
May 29, 2015

Conversation

ceejatec
Copy link
Contributor

No description provided.

@tianon
Copy link
Member

tianon commented May 14, 2015

I've thrown my comments into a concrete proposal (aka, PR): couchbase/docker#2. 👍 ❤️

@tianon
Copy link
Member

tianon commented May 27, 2015

@ceejatec you're going to update this PR, right? 😉

@ceejatec
Copy link
Contributor Author

Ah, yes - sorry, I hadn't realized I needed to update this PR based on your changes, but of course since the library file has the commit SHA in it, I do. Coming right up.

@yosifkit
Copy link
Member

@ceejatec, having an issue building 4.0.0-dp:

Step 5 : RUN rpm --install $CB_RELEASE_URL/$CB_VERSION/$CB_PACKAGE
 ---> Running in 1a5d2e342e55
curl: (22) The requested URL returned error: 403 Forbidden
error: skipping http://packages.couchbase.com/releases/feature/dp/couchbase-server-enterprise-4.0.0-dp-centos6.x86_64.rpm - transfer failed
time="2015-05-28T16:26:15-07:00" level=info msg="The command [/bin/sh -c rpm --install $CB_RELEASE_URL/$CB_VERSION/$CB_PACKAGE] returned a non-zero code: 1" 

@ceejatec
Copy link
Contributor Author

There was a problem with our Dockerfile generator for the 4.0.0-foo images, but I'm not sure if we want to have "official" versions of those anyway. For now I've deleted them from this proposal. We will add them later if we decide to (hopefully that's a low-impact change once the initial Official Images are created).

@yosifkit
Copy link
Member

No problem! It wouldn't be hard to add other versions later. As long as there is no major changes to the Dockerfile and script, it is easy for us (your dockerfiles are all from a template, so it makes it really nice to review 💜).

LGTM, Build test of #729; 303ad5a (couchbase):

$ url="https://raw.githubusercontent.com/docker-library/official-images/303ad5a3a108ad8d97d8fb86b7d620388564db76/library/couchbase"
$ bashbrew build "$url"
Cloning couchbase (git://github.com/couchbase/docker) ...
Processing couchbase:latest ...
Processing couchbase:enterprise ...
Processing couchbase:3.0.3 ...
Processing couchbase:enterprise-3.0.3 ...
Processing couchbase:3.0.2 ...
Processing couchbase:enterprise-3.0.2 ...
Processing couchbase:community ...
Processing couchbase:community-3.0.1 ...
Processing couchbase:2.5.2 ...
Processing couchbase:enterprise-2.5.2 ...
Processing couchbase:community-2.2.0 ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing couchbase:latest
    'utc' [1/3]...passed
    'cve-2014--shellshock' [2/3]...passed
    'no-root-password' [3/3]...warning: locked password detected for root: '!!$6$52kSIL64$OZIz1iImPT2r5C68dupS1HE9FbUdAQ9m8Kb8MXFvRTJJ2ox9ldMm7hDTUKFGxXKx78IB0tS5hg3EAYce3nIyy1'
passed
testing couchbase:3.0.2
    'utc' [1/3]...passed
    'cve-2014--shellshock' [2/3]...passed
    'no-root-password' [3/3]...warning: locked password detected for root: '!!$6$52kSIL64$OZIz1iImPT2r5C68dupS1HE9FbUdAQ9m8Kb8MXFvRTJJ2ox9ldMm7hDTUKFGxXKx78IB0tS5hg3EAYce3nIyy1'
passed
testing couchbase:community
    'utc' [1/3]...passed
    'cve-2014--shellshock' [2/3]...passed
    'no-root-password' [3/3]...warning: locked password detected for root: '!!$6$52kSIL64$OZIz1iImPT2r5C68dupS1HE9FbUdAQ9m8Kb8MXFvRTJJ2ox9ldMm7hDTUKFGxXKx78IB0tS5hg3EAYce3nIyy1'
passed
testing couchbase:2.5.2
    'utc' [1/3]...passed
    'cve-2014--shellshock' [2/3]...passed
    'no-root-password' [3/3]...warning: locked password detected for root: '!!$6$52kSIL64$OZIz1iImPT2r5C68dupS1HE9FbUdAQ9m8Kb8MXFvRTJJ2ox9ldMm7hDTUKFGxXKx78IB0tS5hg3EAYce3nIyy1'
passed
testing couchbase:community-2.2.0
    'utc' [1/3]...passed
    'cve-2014--shellshock' [2/3]...passed
    'no-root-password' [3/3]...warning: locked password detected for root: '!!$6$52kSIL64$OZIz1iImPT2r5C68dupS1HE9FbUdAQ9m8Kb8MXFvRTJJ2ox9ldMm7hDTUKFGxXKx78IB0tS5hg3EAYce3nIyy1'
passed

@tianon
Copy link
Member

tianon commented May 29, 2015

After this is built and pushed, we should probably talk about removing the older 3.0.2 and only keep "latest" of each supported major version -- the older tags will stick around, but since there won't ever be a 3.0.2.1 if there's a problem discovered in 3.0.2, we prefer they not stick around as "supported" (since they really aren't).

@tianon
Copy link
Member

tianon commented May 29, 2015

LGTM

tianon added a commit that referenced this pull request May 29, 2015
Add Couchbase Server Official Docker image.
@tianon tianon merged commit 4eb4930 into docker-library:master May 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants