[maven] Update to 3.3.3

[carlossg]

Make latest point to JDK-8

[tianon]

Have you done testing to verify that USER maven doesn't break the way people have been using the maven image previously?

For example, https://github.com/jlrigau/ci-mesos/blob/058a5fdd659d311a432fd149454d98f4d6457501/maven-git/Dockerfile and https://github.com/darnould/maven-rpm/blob/1450e90596d2e045f2613feb22c9dec8b1a55d04/Dockerfile.

This is the main reason that most of the language stack official images stay as USER root; since they're the base for others to build their application on top of or using, they're not as easily transitioned to unilaterally "non-root" as something like MySQL can be, for instance (because people installing new stuff inside the MySQL image is much more rare than installing new packages on top of the image of a build tool).

[carlossg]

ok, I used jenkins as an example, but if the recommended practice is to use root I'll change it

[tianon]

Well, jenkins is a service generally, so I think installing additional packages on top of it is probably less common than doing so on maven, which is a project build tool, right?

[carlossg]

yep, will change and update the PR

[tianon]

Thanks! ❤️ 👍

[carlossg]

Updated

[tianon]

LGTM (carlossg/docker-maven@d92da50...882a217)

Build test of #690; 469830c (maven):

$ url="https://raw.githubusercontent.com/docker-library/official-images/469830cc12c86cb9933459dc261209a4535822c0/library/maven"
$ bashbrew build "$url"
Cloning maven (git://github.com/carlossg/docker-maven) ...
Processing maven:3.3.3-jdk-7 ...
Processing maven:3.3-jdk-7 ...
Processing maven:3-jdk-7 ...
Processing maven:3.3.3-jdk-7-onbuild ...
Processing maven:3.3-jdk-7-onbuild ...
Processing maven:3-jdk-7-onbuild ...
Processing maven:3.3.3-jdk-8 ...
Processing maven:3.3.3 ...
Processing maven:3.3-jdk-8 ...
Processing maven:3.3 ...
Processing maven:3-jdk-8 ...
Processing maven:3 ...
Processing maven:latest ...
Processing maven:3.3.3-jdk-8-onbuild ...
Processing maven:3.3.3-onbuild ...
Processing maven:3.3-jdk-8-onbuild ...
Processing maven:3.3-onbuild ...
Processing maven:3-jdk-8-onbuild ...
Processing maven:3-onbuild ...
Processing maven:onbuild ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing maven:3.3.3-jdk-7
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing maven:3.3.3-jdk-7-onbuild
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing maven:3.3.3-jdk-8
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing maven:3.3.3-jdk-8-onbuild
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed

[yosifkit]

LGTM