Update cassandra #6223
Merged
Update cassandra #6223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - docker-library/cassandra@5b7eebb: Use explicit "hkps" for keys.openpgp.org - docker-library/cassandra@7b1c4d9: Switch from ha.pool.sks-keyservers.net to keys.openpgp.org for fetching Tianon's PGP key - docker-library/cassandra@d8f3c2a: Update generated README
Diff:diff --git a/cassandra_2.1/Dockerfile b/cassandra_2.1/Dockerfile
index 87a3772..b75239a 100644
--- a/cassandra_2.1/Dockerfile
+++ b/cassandra_2.1/Dockerfile
@@ -4,9 +4,10 @@ FROM debian:stretch-slim
# explicitly set user/group IDs
RUN groupadd -r cassandra --gid=999 && useradd -r -g cassandra --uid=999 cassandra
-RUN set -ex; \
+RUN set -eux; \
apt-get update; \
apt-get install -y --no-install-recommends \
+ gnupg dirmngr \
# solves warning: "jemalloc shared library could not be preloaded to speed up memory allocations"
libjemalloc1 \
# free is used by cassandra-env.sh
@@ -14,28 +15,27 @@ RUN set -ex; \
# "ip" is not required by Cassandra itself, but is commonly used in scripting Cassandra's configuration (since it is so fixated on explicit IP addresses)
iproute2 \
; \
- if ! command -v gpg > /dev/null; then \
- apt-get install -y --no-install-recommends \
- dirmngr \
- gnupg \
- ; \
- fi; \
rm -rf /var/lib/apt/lists/*
# grab gosu for easy step-down from root
ENV GOSU_VERSION 1.10
-RUN set -x \
- && apt-get update && apt-get install -y --no-install-recommends ca-certificates wget && rm -rf /var/lib/apt/lists/* \
- && wget -O /usr/local/bin/gosu "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$(dpkg --print-architecture)" \
- && wget -O /usr/local/bin/gosu.asc "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$(dpkg --print-architecture).asc" \
- && export GNUPGHOME="$(mktemp -d)" \
- && gpg --batch --keyserver ha.pool.sks-keyservers.net --recv-keys B42F6819007F00F88E364FD4036A9C25BF357DD4 \
- && gpg --batch --verify /usr/local/bin/gosu.asc /usr/local/bin/gosu \
- && { command -v gpgconf && gpgconf --kill all || :; } \
- && rm -rf "$GNUPGHOME" /usr/local/bin/gosu.asc \
- && chmod +x /usr/local/bin/gosu \
- && gosu nobody true \
- && apt-get purge -y --auto-remove ca-certificates wget
+RUN set -eux; \
+ savedAptMark="$(apt-mark showmanual)"; \
+ apt-get update; \
+ apt-get install -y --no-install-recommends ca-certificates wget; \
+ rm -rf /var/lib/apt/lists/*; \
+ wget -O /usr/local/bin/gosu "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$(dpkg --print-architecture)"; \
+ wget -O /usr/local/bin/gosu.asc "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$(dpkg --print-architecture).asc"; \
+ export GNUPGHOME="$(mktemp -d)"; \
+ gpg --batch --keyserver hkps://keys.openpgp.org --recv-keys B42F6819007F00F88E364FD4036A9C25BF357DD4; \
+ gpg --batch --verify /usr/local/bin/gosu.asc /usr/local/bin/gosu; \
+ gpgconf --kill all; \
+ rm -rf "$GNUPGHOME" /usr/local/bin/gosu.asc; \
+ chmod +x /usr/local/bin/gosu; \
+ apt-mark auto '.*' > /dev/null; \
+ apt-mark manual $savedAptMark > /dev/null; \
+ apt-get purge -y --auto-remove -o APT::AutoRemove::RecommendsImportant=false; \
+ gosu nobody true
# https://wiki.apache.org/cassandra/DebianPackaging#Adding_Repository_Keys
ENV GPG_KEYS \
@@ -43,7 +43,7 @@ ENV GPG_KEYS \
514A2AD631A57A16DD0047EC749D6EEC0353B12C \
# gpg: key FE4B2BDA: public key "Michael Shuler <michael@pbandjelly.org>" imported
A26E528B271F19B9E5D8E19EA278B781FE4B2BDA
-RUN set -ex; \
+RUN set -eux; \
export GNUPGHOME="$(mktemp -d)"; \
for key in $GPG_KEYS; do \
gpg --batch --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
@@ -55,7 +55,7 @@ RUN set -ex; \
ENV CASSANDRA_VERSION 2.1.21
-RUN set -ex; \
+RUN set -eux; \
\
# https://bugs.debian.org/877677
# update-alternatives: error: error creating symbolic link '/usr/share/man/man1/rmid.1.gz.dpkg-tmp': No such file or directory
@@ -115,7 +115,7 @@ RUN set -ex; \
\
rm -rf /var/lib/apt/lists/*; \
\
- if [ -n "$tempDir" ]; then \
+ if [ -n "${tempDir:-}" ]; then \
# if we have leftovers from building, let's purge them (including extra, unnecessary build deps)
apt-get purge -y --auto-remove; \
rm -rf "$tempDir" /etc/apt/sources.list.d/temp.list; \
@@ -123,7 +123,7 @@ RUN set -ex; \
ENV CASSANDRA_CONFIG /etc/cassandra
-RUN set -ex; \
+RUN set -eux; \
\
dpkgArch="$(dpkg --print-architecture)"; \
case "$dpkgArch" in \
diff --git a/cassandra_2/Dockerfile b/cassandra_2/Dockerfile
index caeb86e..cd52444 100644
--- a/cassandra_2/Dockerfile
+++ b/cassandra_2/Dockerfile
@@ -4,9 +4,10 @@ FROM debian:stretch-slim
# explicitly set user/group IDs
RUN groupadd -r cassandra --gid=999 && useradd -r -g cassandra --uid=999 cassandra
-RUN set -ex; \
+RUN set -eux; \
apt-get update; \
apt-get install -y --no-install-recommends \
+ gnupg dirmngr \
# solves warning: "jemalloc shared library could not be preloaded to speed up memory allocations"
libjemalloc1 \
# free is used by cassandra-env.sh
@@ -14,28 +15,27 @@ RUN set -ex; \
# "ip" is not required by Cassandra itself, but is commonly used in scripting Cassandra's configuration (since it is so fixated on explicit IP addresses)
iproute2 \
; \
- if ! command -v gpg > /dev/null; then \
- apt-get install -y --no-install-recommends \
- dirmngr \
- gnupg \
- ; \
- fi; \
rm -rf /var/lib/apt/lists/*
# grab gosu for easy step-down from root
ENV GOSU_VERSION 1.10
-RUN set -x \
- && apt-get update && apt-get install -y --no-install-recommends ca-certificates wget && rm -rf /var/lib/apt/lists/* \
- && wget -O /usr/local/bin/gosu "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$(dpkg --print-architecture)" \
- && wget -O /usr/local/bin/gosu.asc "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$(dpkg --print-architecture).asc" \
- && export GNUPGHOME="$(mktemp -d)" \
- && gpg --batch --keyserver ha.pool.sks-keyservers.net --recv-keys B42F6819007F00F88E364FD4036A9C25BF357DD4 \
- && gpg --batch --verify /usr/local/bin/gosu.asc /usr/local/bin/gosu \
- && { command -v gpgconf && gpgconf --kill all || :; } \
- && rm -rf "$GNUPGHOME" /usr/local/bin/gosu.asc \
- && chmod +x /usr/local/bin/gosu \
- && gosu nobody true \
- && apt-get purge -y --auto-remove ca-certificates wget
+RUN set -eux; \
+ savedAptMark="$(apt-mark showmanual)"; \
+ apt-get update; \
+ apt-get install -y --no-install-recommends ca-certificates wget; \
+ rm -rf /var/lib/apt/lists/*; \
+ wget -O /usr/local/bin/gosu "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$(dpkg --print-architecture)"; \
+ wget -O /usr/local/bin/gosu.asc "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$(dpkg --print-architecture).asc"; \
+ export GNUPGHOME="$(mktemp -d)"; \
+ gpg --batch --keyserver hkps://keys.openpgp.org --recv-keys B42F6819007F00F88E364FD4036A9C25BF357DD4; \
+ gpg --batch --verify /usr/local/bin/gosu.asc /usr/local/bin/gosu; \
+ gpgconf --kill all; \
+ rm -rf "$GNUPGHOME" /usr/local/bin/gosu.asc; \
+ chmod +x /usr/local/bin/gosu; \
+ apt-mark auto '.*' > /dev/null; \
+ apt-mark manual $savedAptMark > /dev/null; \
+ apt-get purge -y --auto-remove -o APT::AutoRemove::RecommendsImportant=false; \
+ gosu nobody true
# https://wiki.apache.org/cassandra/DebianPackaging#Adding_Repository_Keys
ENV GPG_KEYS \
@@ -43,7 +43,7 @@ ENV GPG_KEYS \
514A2AD631A57A16DD0047EC749D6EEC0353B12C \
# gpg: key FE4B2BDA: public key "Michael Shuler <michael@pbandjelly.org>" imported
A26E528B271F19B9E5D8E19EA278B781FE4B2BDA
-RUN set -ex; \
+RUN set -eux; \
export GNUPGHOME="$(mktemp -d)"; \
for key in $GPG_KEYS; do \
gpg --batch --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
@@ -55,7 +55,7 @@ RUN set -ex; \
ENV CASSANDRA_VERSION 2.2.14
-RUN set -ex; \
+RUN set -eux; \
\
# https://bugs.debian.org/877677
# update-alternatives: error: error creating symbolic link '/usr/share/man/man1/rmid.1.gz.dpkg-tmp': No such file or directory
@@ -115,7 +115,7 @@ RUN set -ex; \
\
rm -rf /var/lib/apt/lists/*; \
\
- if [ -n "$tempDir" ]; then \
+ if [ -n "${tempDir:-}" ]; then \
# if we have leftovers from building, let's purge them (including extra, unnecessary build deps)
apt-get purge -y --auto-remove; \
rm -rf "$tempDir" /etc/apt/sources.list.d/temp.list; \
@@ -123,7 +123,7 @@ RUN set -ex; \
ENV CASSANDRA_CONFIG /etc/cassandra
-RUN set -ex; \
+RUN set -eux; \
\
dpkgArch="$(dpkg --print-architecture)"; \
case "$dpkgArch" in \
diff --git a/cassandra_3.0/Dockerfile b/cassandra_3.0/Dockerfile
index 1d8c362..5aa1256 100644
--- a/cassandra_3.0/Dockerfile
+++ b/cassandra_3.0/Dockerfile
@@ -4,9 +4,10 @@ FROM debian:stretch-slim
# explicitly set user/group IDs
RUN groupadd -r cassandra --gid=999 && useradd -r -g cassandra --uid=999 cassandra
-RUN set -ex; \
+RUN set -eux; \
apt-get update; \
apt-get install -y --no-install-recommends \
+ gnupg dirmngr \
# solves warning: "jemalloc shared library could not be preloaded to speed up memory allocations"
libjemalloc1 \
# free is used by cassandra-env.sh
@@ -14,28 +15,27 @@ RUN set -ex; \
# "ip" is not required by Cassandra itself, but is commonly used in scripting Cassandra's configuration (since it is so fixated on explicit IP addresses)
iproute2 \
; \
- if ! command -v gpg > /dev/null; then \
- apt-get install -y --no-install-recommends \
- dirmngr \
- gnupg \
- ; \
- fi; \
rm -rf /var/lib/apt/lists/*
# grab gosu for easy step-down from root
ENV GOSU_VERSION 1.10
-RUN set -x \
- && apt-get update && apt-get install -y --no-install-recommends ca-certificates wget && rm -rf /var/lib/apt/lists/* \
- && wget -O /usr/local/bin/gosu "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$(dpkg --print-architecture)" \
- && wget -O /usr/local/bin/gosu.asc "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$(dpkg --print-architecture).asc" \
- && export GNUPGHOME="$(mktemp -d)" \
- && gpg --batch --keyserver ha.pool.sks-keyservers.net --recv-keys B42F6819007F00F88E364FD4036A9C25BF357DD4 \
- && gpg --batch --verify /usr/local/bin/gosu.asc /usr/local/bin/gosu \
- && { command -v gpgconf && gpgconf --kill all || :; } \
- && rm -rf "$GNUPGHOME" /usr/local/bin/gosu.asc \
- && chmod +x /usr/local/bin/gosu \
- && gosu nobody true \
- && apt-get purge -y --auto-remove ca-certificates wget
+RUN set -eux; \
+ savedAptMark="$(apt-mark showmanual)"; \
+ apt-get update; \
+ apt-get install -y --no-install-recommends ca-certificates wget; \
+ rm -rf /var/lib/apt/lists/*; \
+ wget -O /usr/local/bin/gosu "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$(dpkg --print-architecture)"; \
+ wget -O /usr/local/bin/gosu.asc "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$(dpkg --print-architecture).asc"; \
+ export GNUPGHOME="$(mktemp -d)"; \
+ gpg --batch --keyserver hkps://keys.openpgp.org --recv-keys B42F6819007F00F88E364FD4036A9C25BF357DD4; \
+ gpg --batch --verify /usr/local/bin/gosu.asc /usr/local/bin/gosu; \
+ gpgconf --kill all; \
+ rm -rf "$GNUPGHOME" /usr/local/bin/gosu.asc; \
+ chmod +x /usr/local/bin/gosu; \
+ apt-mark auto '.*' > /dev/null; \
+ apt-mark manual $savedAptMark > /dev/null; \
+ apt-get purge -y --auto-remove -o APT::AutoRemove::RecommendsImportant=false; \
+ gosu nobody true
# https://wiki.apache.org/cassandra/DebianPackaging#Adding_Repository_Keys
ENV GPG_KEYS \
@@ -43,7 +43,7 @@ ENV GPG_KEYS \
514A2AD631A57A16DD0047EC749D6EEC0353B12C \
# gpg: key FE4B2BDA: public key "Michael Shuler <michael@pbandjelly.org>" imported
A26E528B271F19B9E5D8E19EA278B781FE4B2BDA
-RUN set -ex; \
+RUN set -eux; \
export GNUPGHOME="$(mktemp -d)"; \
for key in $GPG_KEYS; do \
gpg --batch --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
@@ -55,7 +55,7 @@ RUN set -ex; \
ENV CASSANDRA_VERSION 3.0.18
-RUN set -ex; \
+RUN set -eux; \
\
# https://bugs.debian.org/877677
# update-alternatives: error: error creating symbolic link '/usr/share/man/man1/rmid.1.gz.dpkg-tmp': No such file or directory
@@ -115,7 +115,7 @@ RUN set -ex; \
\
rm -rf /var/lib/apt/lists/*; \
\
- if [ -n "$tempDir" ]; then \
+ if [ -n "${tempDir:-}" ]; then \
# if we have leftovers from building, let's purge them (including extra, unnecessary build deps)
apt-get purge -y --auto-remove; \
rm -rf "$tempDir" /etc/apt/sources.list.d/temp.list; \
@@ -123,7 +123,7 @@ RUN set -ex; \
ENV CASSANDRA_CONFIG /etc/cassandra
-RUN set -ex; \
+RUN set -eux; \
\
dpkgArch="$(dpkg --print-architecture)"; \
case "$dpkgArch" in \
diff --git a/cassandra_latest/Dockerfile b/cassandra_latest/Dockerfile
index 6c823db..f243702 100644
--- a/cassandra_latest/Dockerfile
+++ b/cassandra_latest/Dockerfile
@@ -4,9 +4,10 @@ FROM debian:stretch-slim
# explicitly set user/group IDs
RUN groupadd -r cassandra --gid=999 && useradd -r -g cassandra --uid=999 cassandra
-RUN set -ex; \
+RUN set -eux; \
apt-get update; \
apt-get install -y --no-install-recommends \
+ gnupg dirmngr \
# solves warning: "jemalloc shared library could not be preloaded to speed up memory allocations"
libjemalloc1 \
# free is used by cassandra-env.sh
@@ -14,28 +15,27 @@ RUN set -ex; \
# "ip" is not required by Cassandra itself, but is commonly used in scripting Cassandra's configuration (since it is so fixated on explicit IP addresses)
iproute2 \
; \
- if ! command -v gpg > /dev/null; then \
- apt-get install -y --no-install-recommends \
- dirmngr \
- gnupg \
- ; \
- fi; \
rm -rf /var/lib/apt/lists/*
# grab gosu for easy step-down from root
ENV GOSU_VERSION 1.10
-RUN set -x \
- && apt-get update && apt-get install -y --no-install-recommends ca-certificates wget && rm -rf /var/lib/apt/lists/* \
- && wget -O /usr/local/bin/gosu "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$(dpkg --print-architecture)" \
- && wget -O /usr/local/bin/gosu.asc "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$(dpkg --print-architecture).asc" \
- && export GNUPGHOME="$(mktemp -d)" \
- && gpg --batch --keyserver ha.pool.sks-keyservers.net --recv-keys B42F6819007F00F88E364FD4036A9C25BF357DD4 \
- && gpg --batch --verify /usr/local/bin/gosu.asc /usr/local/bin/gosu \
- && { command -v gpgconf && gpgconf --kill all || :; } \
- && rm -rf "$GNUPGHOME" /usr/local/bin/gosu.asc \
- && chmod +x /usr/local/bin/gosu \
- && gosu nobody true \
- && apt-get purge -y --auto-remove ca-certificates wget
+RUN set -eux; \
+ savedAptMark="$(apt-mark showmanual)"; \
+ apt-get update; \
+ apt-get install -y --no-install-recommends ca-certificates wget; \
+ rm -rf /var/lib/apt/lists/*; \
+ wget -O /usr/local/bin/gosu "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$(dpkg --print-architecture)"; \
+ wget -O /usr/local/bin/gosu.asc "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$(dpkg --print-architecture).asc"; \
+ export GNUPGHOME="$(mktemp -d)"; \
+ gpg --batch --keyserver hkps://keys.openpgp.org --recv-keys B42F6819007F00F88E364FD4036A9C25BF357DD4; \
+ gpg --batch --verify /usr/local/bin/gosu.asc /usr/local/bin/gosu; \
+ gpgconf --kill all; \
+ rm -rf "$GNUPGHOME" /usr/local/bin/gosu.asc; \
+ chmod +x /usr/local/bin/gosu; \
+ apt-mark auto '.*' > /dev/null; \
+ apt-mark manual $savedAptMark > /dev/null; \
+ apt-get purge -y --auto-remove -o APT::AutoRemove::RecommendsImportant=false; \
+ gosu nobody true
# https://wiki.apache.org/cassandra/DebianPackaging#Adding_Repository_Keys
ENV GPG_KEYS \
@@ -43,7 +43,7 @@ ENV GPG_KEYS \
514A2AD631A57A16DD0047EC749D6EEC0353B12C \
# gpg: key FE4B2BDA: public key "Michael Shuler <michael@pbandjelly.org>" imported
A26E528B271F19B9E5D8E19EA278B781FE4B2BDA
-RUN set -ex; \
+RUN set -eux; \
export GNUPGHOME="$(mktemp -d)"; \
for key in $GPG_KEYS; do \
gpg --batch --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
@@ -55,7 +55,7 @@ RUN set -ex; \
ENV CASSANDRA_VERSION 3.11.4
-RUN set -ex; \
+RUN set -eux; \
\
# https://bugs.debian.org/877677
# update-alternatives: error: error creating symbolic link '/usr/share/man/man1/rmid.1.gz.dpkg-tmp': No such file or directory
@@ -115,7 +115,7 @@ RUN set -ex; \
\
rm -rf /var/lib/apt/lists/*; \
\
- if [ -n "$tempDir" ]; then \
+ if [ -n "${tempDir:-}" ]; then \
# if we have leftovers from building, let's purge them (including extra, unnecessary build deps)
apt-get purge -y --auto-remove; \
rm -rf "$tempDir" /etc/apt/sources.list.d/temp.list; \
@@ -123,7 +123,7 @@ RUN set -ex; \
ENV CASSANDRA_CONFIG /etc/cassandra
-RUN set -ex; \
+RUN set -eux; \
\
dpkgArch="$(dpkg --print-architecture)"; \
case "$dpkgArch" in \ |
|
Build test of #6223; cace9e9; $ bashbrew build cassandra:2.1.21
Building bashbrew/cache:9ae11f54265f41c467f7e66e499b1ba0c56e861a783dd0c90c744e1e59444467 (cassandra:2.1.21)
Tagging cassandra:2.1.21
Tagging cassandra:2.1
$ test/run.sh cassandra:2.1.21
testing cassandra:2.1.21
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'cassandra-basics' [5/5]......passed
$ bashbrew build cassandra:2.2.14
Building bashbrew/cache:8d19c4c1e0fc78e4a852c006a74112e4db5950be4dcb963f8f814bc870085441 (cassandra:2.2.14)
Tagging cassandra:2.2.14
Tagging cassandra:2.2
Tagging cassandra:2
$ test/run.sh cassandra:2.2.14
testing cassandra:2.2.14
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'cassandra-basics' [5/5]......passed
$ bashbrew build cassandra:3.0.18
Building bashbrew/cache:7aa26546cde0e30cb5e23ddf81d72012ee6849f5eab2ed2f37160ec6fb3aee95 (cassandra:3.0.18)
Tagging cassandra:3.0.18
Tagging cassandra:3.0
$ test/run.sh cassandra:3.0.18
testing cassandra:3.0.18
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'cassandra-basics' [5/5]......passed
$ bashbrew build cassandra:3.11.4
Building bashbrew/cache:1b6cde26d414f799cee017eb0ded5207241c90e54437f31db482f2c9e21d6a0e (cassandra:3.11.4)
Tagging cassandra:3.11.4
Tagging cassandra:3.11
Tagging cassandra:3
Tagging cassandra:latest
$ test/run.sh cassandra:3.11.4
testing cassandra:3.11.4
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'cassandra-basics' [5/5]......passed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: