Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nats] Release v1.4.0 #5298

Merged
merged 1 commit into from
Jan 15, 2019
Merged

[nats] Release v1.4.0 #5298

merged 1 commit into from
Jan 15, 2019

Conversation

kozlovic
Copy link
Contributor

Details can be found here

Signed-off-by: Ivan Kozlovic ivan@synadia.com

Details can be found [here](https://github.com/nats-io/gnatsd/releases/tag/v1.4.0)

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@tianon
Copy link
Member

tianon commented Jan 15, 2019

Diff:
diff --git a/_bashbrew-list b/_bashbrew-list
index fe97fb7..108541d 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -1,7 +1,7 @@
-nats:1.3.0
-nats:1.3.0-linux
-nats:1.3.0-nanoserver
-nats:1.3.0-windowsservercore
+nats:1.4.0
+nats:1.4.0-linux
+nats:1.4.0-nanoserver
+nats:1.4.0-windowsservercore
 nats:latest
 nats:linux
 nats:nanoserver
diff --git a/_bashbrew-shared-tags b/_bashbrew-shared-tags
index 52efc0c..5c7ad86 100644
--- a/_bashbrew-shared-tags
+++ b/_bashbrew-shared-tags
@@ -1,2 +1,2 @@
-nats:1.3.0 -- nats:linux, nats:nanoserver
+nats:1.4.0 -- nats:linux, nats:nanoserver
 nats:latest -- nats:linux, nats:nanoserver
diff --git a/nats_linux/gnatsd b/nats_linux/gnatsd
index b861638..cf4f345 100755
Binary files a/nats_linux/gnatsd and b/nats_linux/gnatsd differ
diff --git a/nats_nanoserver/gnatsd.exe b/nats_nanoserver/gnatsd.exe
index a8bc39d..0c58afc 100755
Binary files a/nats_nanoserver/gnatsd.exe and b/nats_nanoserver/gnatsd.exe differ
diff --git a/nats_windowsservercore/gnatsd.exe b/nats_windowsservercore/gnatsd.exe
index a8bc39d..0c58afc 100755
Binary files a/nats_windowsservercore/gnatsd.exe and b/nats_windowsservercore/gnatsd.exe differ

@tianon
Copy link
Member

tianon commented Jan 15, 2019

LGTM

Build test of #5298; d19d42d; amd64 (nats):

$ bashbrew build nats:1.4.0-linux
Building bashbrew/cache:cef2c08bc8afee95c3f86c605e78956dc392139a2518eab924e74777f085f46a (nats:1.4.0-linux)
Tagging nats:1.4.0-linux
Tagging nats:linux
Tagging nats:1.4.0
Tagging nats:latest

$ test/run.sh nats:1.4.0-linux
testing nats:1.4.0-linux
	'cve-2014--shellshock' [1/2]...passed
	'override-cmd' [2/2]...image does not appear to contain "echo" -- assuming single-binary image
passed


$ bashbrew build nats:1.4.0-nanoserver
skipping "nats:1.4.0-nanoserver" (due to architecture "amd64"; only "windows-amd64" supported)

$ test/run.sh nats:1.4.0-nanoserver
testing nats:1.4.0-nanoserver
	image does not exist!


$ bashbrew build nats:1.4.0-windowsservercore
skipping "nats:1.4.0-windowsservercore" (due to architecture "amd64"; only "windows-amd64" supported)

$ test/run.sh nats:1.4.0-windowsservercore
testing nats:1.4.0-windowsservercore
	image does not exist!

The following images failed at least one test:

  • nats:
    • nats:1.4.0-nanoserver
    • nats:1.4.0-windowsservercore

@tianon tianon merged commit ea91bc1 into docker-library:master Jan 15, 2019
@kozlovic kozlovic deleted the nats_1_4_0 branch January 15, 2019 23:32
@kozlovic
Copy link
Contributor Author

@tianon Thanks! Do you automatically look for corresponding PR in doc or should I link the doc PR when submitting to official-images so that you don't have to look for it?
In case, here is the corresponding doc for this PR: docker-library/docs#1401

@yosifkit
Copy link
Member

We don't often look for a docs PR at the same time as an update PR, since most of the time we don't have one. We just process the queue of new PRs in each repo. (but your link is helpful to remind us that they go together)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants