Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aerospike 4.4.0.6 #5173

Merged
merged 9 commits into from
Dec 13, 2018
Merged

Aerospike 4.4.0.6 #5173

merged 9 commits into from
Dec 13, 2018

Conversation

volmarl
Copy link
Contributor

@volmarl volmarl commented Dec 12, 2018

@volmarl
Copy link
Contributor Author

volmarl commented Dec 12, 2018

@yosifkit Any idea on why the new manifest format is failing?

@volmarl
Copy link
Contributor Author

volmarl commented Dec 12, 2018

nvm @yosifkit , Looks like there can't be an initial GitRepo line by itself.

@tianon
Copy link
Member

tianon commented Dec 13, 2018

GitRepo: can be global, but it needs to be adjacent to Maintainers: for that to work (the "sections" of the file are newline separated, and the first section is the "global" section).

Diff:
diff --git a/_bashbrew-list b/_bashbrew-list
index 118e9a6..c3829e1 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -1,3 +1,3 @@
 aerospike:3.13.0.11
-aerospike:4.4.0.5
+aerospike:4.4.0.6
 aerospike:latest
diff --git a/aerospike_latest/Dockerfile b/aerospike_latest/Dockerfile
index 7999685..360b89a 100644
--- a/aerospike_latest/Dockerfile
+++ b/aerospike_latest/Dockerfile
@@ -6,8 +6,8 @@
 
 FROM debian:stretch-slim 
 
-ENV AEROSPIKE_VERSION 4.4.0.5
-ENV AEROSPIKE_SHA256 036b52b4098ba11a4cabe31f1469c7a211e6591413f30c7fd6fa1f510e86aeea
+ENV AEROSPIKE_VERSION 4.4.0.6
+ENV AEROSPIKE_SHA256 09197428e79a78d4c3646507f8168cea81d0441600e31daabe085ba9f789a1a7
 
 # Install Aerospike Server and Tools
 
diff --git a/aerospike_latest/aerospike.template.conf b/aerospike_latest/aerospike.template.conf
index 8f53307..06ecc70 100644
--- a/aerospike_latest/aerospike.template.conf
+++ b/aerospike_latest/aerospike.template.conf
@@ -73,7 +73,7 @@ namespace ${NAMESPACE} {
 	# following lines instead.
 
 	storage-engine device {
-		file /opt/aerospike/data/test.dat
+		file /opt/aerospike/data/${NAMESPACE}.dat
 		filesize ${STORAGE_GB}G
 		data-in-memory true # Store data in memory in addition to file.
 	}

@tianon
Copy link
Member

tianon commented Dec 13, 2018

LGTM

Build test of #5173; 3a2f1ec; amd64 (aerospike):

$ bashbrew build aerospike:4.4.0.6
Building bashbrew/cache:18fc1fb292a4a6fdce55e32c21259de51854502e2272c7227fb7d2d14b73a786 (aerospike:4.4.0.6)
Tagging aerospike:4.4.0.6
Tagging aerospike:latest

$ test/run.sh aerospike:4.4.0.6
testing aerospike:4.4.0.6
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build aerospike:3.13.0.11
Building bashbrew/cache:9a47d7225f7b1dd48b94864010209d2201f3855c03d8d08907e2f32b7e9a401f (aerospike:3.13.0.11)
Tagging aerospike:3.13.0.11

$ test/run.sh aerospike:3.13.0.11
testing aerospike:3.13.0.11
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed

@tianon tianon merged commit d54534a into docker-library:master Dec 13, 2018
@tianon
Copy link
Member

tianon commented Dec 13, 2018

If you wanted to, you could go even further with this:

Maintainers: Lucien Volmar <lucien@aerospike.com> (@volmarl)
GitRepo: https://github.com/aerospike/aerospike-server.docker.git
GitCommit: 026024b1d24866a0860afd72e2300151e026e872

Tags: 4.4.0.6, latest

(Reminder that removing tags here will remove them from the "Supported" section on the Hub readme and will prevent us from spending cycles rebuilding them on the official build server, but the tag will still be available to users who want it. See https://github.com/docker-library/official-images#library-definition-files for more detail on this.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants