Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security] Update Node.js for November 2018 security releases #5115

Conversation

rvagg
Copy link
Contributor

@rvagg rvagg commented Nov 28, 2018

@tianon
Copy link
Member

tianon commented Nov 28, 2018

(Just to thread the needle -- Travis is failing here because nodejs/docker-node#938 isn't merged yet.)

@rvagg
Copy link
Contributor Author

rvagg commented Nov 28, 2018

nodejs/docker-node#938 merged now

@yosifkit
Copy link
Member

Waiting on nodejs/docker-node#939

@SimenB SimenB mentioned this pull request Nov 28, 2018
@SimenB
Copy link
Contributor

SimenB commented Nov 28, 2018

#5116

@larister
Copy link

Thanks for all the work on this. Any ideas why the check is still failing? Looks like conflict resolution is needed...

@SimenB
Copy link
Contributor

SimenB commented Nov 28, 2018

@larister conflict because #5116 has been merged, the updated images are available as soon as the build completes

@larister
Copy link

Ok thanks @SimenB; forgive me ignorance but which build are you talking about? The one triggered by #5116 has already completed a while ago but I still can't seem to build FROM node:8.14.0

@SimenB
Copy link
Contributor

SimenB commented Nov 28, 2018

https://doi-janky.infosiftr.net/job/multiarch/view/images/view/node/

@tianon
Copy link
Member

tianon commented Nov 28, 2018

Closing given #5116 (which replaced this).

@tianon tianon closed this Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants